Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra prerequisite from makefile rules in programming guide and examples #1883

Merged
merged 2 commits into from
Oct 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion programming_examples/basic/dma_transpose/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ else
cp _build/${targetname} $@
endif

run: ${targetname}.exe build/final.xclbin build/insts.txt
run: ${targetname}.exe build/final.xclbin
${powershell} ./$< -x build/final.xclbin -i build/insts.txt -k MLIR_AIE --M ${M} --K ${K}

clean:
Expand Down
2 changes: 1 addition & 1 deletion programming_examples/basic/matrix_scalar_add/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ vck5000: build/aie.mlir
-Wl,-R/opt/xaiengine/lib \
-Wl,--whole-archive -Wl,--no-whole-archive -lstdc++ -ldl -lelf -o test.elf

run: ${targetname}.exe build/final.xclbin build/insts.txt
run: ${targetname}.exe build/final.xclbin
${powershell} ./$< -x build/final.xclbin -i build/insts.txt -k MLIR_AIE

clean:
Expand Down
2 changes: 1 addition & 1 deletion programming_examples/basic/passthrough_dmas/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ else
cp _build/${targetname} $@
endif

run: ${targetname}.exe build/final.xclbin build/insts.txt
run: ${targetname}.exe build/final.xclbin
${powershell} ./$< -x build/final.xclbin -i build/insts.txt -k MLIR_AIE -l ${LENGTH}

# Changing variables when we target VCK5000
Expand Down
2 changes: 1 addition & 1 deletion programming_examples/basic/vector_exp/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ else
cp _build/${targetname} $@
endif

run: ${targetname}.exe build/final.xclbin build/insts.txt
run: ${targetname}.exe build/final.xclbin
${powershell} ./$< -x build/final.xclbin -i build/insts.txt -k MLIR_AIE

clean:
Expand Down
2 changes: 1 addition & 1 deletion programming_examples/basic/vector_reduce_add/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ else
cp _build/${targetname} $@
endif

run: ${targetname}.exe build/final.xclbin build/insts.txt
run: ${targetname}.exe build/final.xclbin
${powershell} ./$< -x build/final.xclbin -i build/insts.txt -k MLIR_AIE

trace:
Expand Down
2 changes: 1 addition & 1 deletion programming_examples/basic/vector_reduce_max/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ else
cp _build/${targetname} $@
endif

run: ${targetname}.exe build/final.xclbin build/insts.txt
run: ${targetname}.exe build/final.xclbin
${powershell} ./$< -x build/final.xclbin -i build/insts.txt -k MLIR_AIE

trace:
Expand Down
2 changes: 1 addition & 1 deletion programming_examples/basic/vector_reduce_min/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ else
cp _build/${targetname} $@
endif

run: ${targetname}.exe build/final.xclbin build/insts.txt
run: ${targetname}.exe build/final.xclbin
${powershell} ./$< -x build/final.xclbin -i build/insts.txt -k MLIR_AIE

trace:
Expand Down
2 changes: 1 addition & 1 deletion programming_examples/basic/vector_scalar_add/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ else
cp _build/${targetname} $@
endif

run: ${targetname}.exe build/final.xclbin build/insts.txt
run: ${targetname}.exe build/final.xclbin
${powershell} ./$< -x build/final.xclbin -i build/insts.txt -k MLIR_AIE

clean:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ else
cp _build/${targetname} $@
endif

run: ${targetname}.exe build/final.xclbin build/insts.txt
run: ${targetname}.exe build/final.xclbin
${powershell} ./$< -x build/final.xclbin -i build/insts.txt -k MLIR_AIE

clean:
Expand Down
2 changes: 1 addition & 1 deletion programming_examples/basic/vector_vector_add/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ vck5000: build/aie.mlir
${srcdir}/../../../install/runtime_lib/x86_64-hsa/test_lib/src/test_library.cpp \
-Wl,--whole-archive -Wl,--no-whole-archive -lstdc++ -ldl -lelf -o test.elf

run: ${targetname}.exe build/final.xclbin build/insts.txt
run: ${targetname}.exe build/final.xclbin
${powershell} ./$< -x build/final.xclbin -i build/insts.txt -k MLIR_AIE

clean:
Expand Down
2 changes: 1 addition & 1 deletion programming_examples/basic/vector_vector_modulo/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ vck5000: build/aie.mlir
-Wl,-R/opt/xaiengine/lib \
-Wl,--whole-archive -Wl,--no-whole-archive -lstdc++ -ldl -lelf -o test.elf

run: ${targetname}.exe build/final.xclbin build/insts.txt
run: ${targetname}.exe build/final.xclbin
${powershell} ./$< -x build/final.xclbin -i build/insts.txt -k MLIR_AIE

clean:
Expand Down
2 changes: 1 addition & 1 deletion programming_examples/basic/vector_vector_mul/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ vck5000: build/aie.mlir
-Wl,--whole-archive -Wl,--no-whole-archive -lstdc++ -ldl -lelf -o test.elf


run: ${targetname}.exe build/final.xclbin build/insts.txt
run: ${targetname}.exe build/final.xclbin
${powershell} ./$< -x build/final.xclbin -i build/insts.txt -k MLIR_AIE

clean:
Expand Down
4 changes: 2 additions & 2 deletions programming_examples/ml/eltwise_add/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,10 @@ else
endif


run: ${targetname}.exe build/final.xclbin build/insts.txt
run: ${targetname}.exe build/final.xclbin
${powershell} ./$< -x build/final.xclbin -i build/insts.txt -k MLIR_AIE

trace: ${targetname}.exe build/final_trace.xclbin build/insts.txt
trace: ${targetname}.exe build/final_trace.xclbin
${powershell} ./$< -x build/final_trace.xclbin -i build/insts.txt -k MLIR_AIE -t ${trace_size}
../../utils/parse_eventIR.py --filename trace.txt --mlir build/aie_trace.mlir --colshift 1 > parse_eventIR_vs.json

Expand Down
4 changes: 2 additions & 2 deletions programming_examples/ml/eltwise_mul/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,10 @@ else
cp _build/${targetname} $@
endif

run: ${targetname}.exe build/final.xclbin build/insts.txt
run: ${targetname}.exe build/final.xclbin
${powershell} ./$< -x build/final.xclbin -i build/insts.txt -k MLIR_AIE

trace: ${targetname}.exe build/final_trace.xclbin build/insts.txt
trace: ${targetname}.exe build/final_trace.xclbin
${powershell} ./$< -x build/final_trace.xclbin -i build/insts.txt -k MLIR_AIE -t ${trace_size}
../../utils/parse_eventIR.py --filename trace.txt --mlir build/aie_trace.mlir --colshift 1 > parse_eventIR_vs.json
clean:
Expand Down
4 changes: 2 additions & 2 deletions programming_examples/ml/relu/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,10 @@ else
cp _build/${targetname} $@
endif

run: ${targetname}.exe build/final.xclbin build/insts.txt
run: ${targetname}.exe build/final.xclbin
${powershell} ./$< -x build/final.xclbin -i build/insts.txt -k MLIR_AIE

trace: ${targetname}.exe build/final_trace.xclbin build/insts.txt
trace: ${targetname}.exe build/final_trace.xclbin
${powershell} ./$< -x build/final_trace.xclbin -i build/insts.txt -k MLIR_AIE -t ${trace_size}
../../utils/parse_eventIR.py --filename trace.txt --mlir build/aie_trace.mlir --colshift 1 > parse_eventIR_vs.json

Expand Down
6 changes: 3 additions & 3 deletions programming_examples/ml/softmax/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -68,13 +68,13 @@ else
cp _build/${targetname} $@
endif

run: ${targetname}.exe build/final.xclbin build/insts.txt
run: ${targetname}.exe build/final.xclbin
${powershell} ./$< -x build/final.xclbin -i build/insts.txt -k MLIR_AIE

profile: ${targetname}.exe build/final.xclbin build/insts.txt
profile: ${targetname}.exe build/final.xclbin
${powershell} ./$< -x build/final.xclbin -i build/insts.txt -k MLIR_AIE -p results.csv

trace: ${targetname}.exe build/final_trace.xclbin build/insts.txt
trace: ${targetname}.exe build/final_trace.xclbin
${powershell} ./$< -x build/final_trace.xclbin -i build/insts.txt -k MLIR_AIE -t ${trace_size}
../../utils/parse_eventIR.py --filename trace.txt --mlir build/aie_trace.mlir --colshift 1 > parse_eventIR_vs.json

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ else
cp _build/${targetname} $@
endif

run: ${targetname}.exe build/final.xclbin build/insts.txt
run: ${targetname}.exe build/final.xclbin
${powershell} ./$< -x build/final.xclbin -i build/insts.txt -k MLIR_AIE

clean:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ else
cp _build/${targetname} $@
endif

run: ${targetname}.exe build/final.xclbin build/insts.txt
run: ${targetname}.exe build/final.xclbin
${powershell} ./$< -x build/final.xclbin -i build/insts.txt -k MLIR_AIE

clean:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ else
cp _build/${targetname} $@
endif

run: ${targetname}.exe build/final.xclbin build/insts.txt
run: ${targetname}.exe build/final.xclbin
${powershell} ./$< -x build/final.xclbin -i build/insts.txt -k MLIR_AIE

clean:
Expand Down
2 changes: 1 addition & 1 deletion programming_guide/section-2/section-2e/05_join_L2/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ else
cp _build/${targetname} $@
endif

run: ${targetname}.exe build/final.xclbin build/insts.txt
run: ${targetname}.exe build/final.xclbin
${powershell} ./$< -x build/final.xclbin -i build/insts.txt -k MLIR_AIE

clean:
Expand Down
2 changes: 1 addition & 1 deletion programming_guide/section-3/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ else
cp _build/${targetname} $@
endif

run: ${targetname}.exe build/final.xclbin build/insts.txt
run: ${targetname}.exe build/final.xclbin
${powershell} ./$< -x build/final.xclbin -i build/insts.txt -k MLIR_AIE

run_py: build/final.xclbin build/insts.txt
Expand Down
2 changes: 1 addition & 1 deletion programming_guide/section-4/section-4a/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ else
cp _build/${targetname} $@
endif

run: ${targetname}.exe build/final.xclbin build/insts.txt
run: ${targetname}.exe build/final.xclbin
${powershell} ./$< -x build/final.xclbin -i build/insts.txt -k MLIR_AIE

run-10: ${targetname}.exe build/final.xclbin build/insts.txt
Expand Down
Loading