Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Initial implementation of baseline MediaVideo component with required link prop and styling #299

Merged
merged 2 commits into from
Aug 26, 2023

Conversation

otaree
Copy link
Contributor

@otaree otaree commented Aug 25, 2023

Create Base MediaVideo Component

Contributor checklist


Description

I've implemented the baseline MediaVideo component based on the user story's requirements. This component includes the following features:

  • A required link prop, enabling the component to display a video or link to a video call.
  • Styling that aligns with the coloration defined in tailwind.config.ts.
  • Appropriate sizing to maintain consistency with other components in the components/media directory.

Testing

I've thoroughly tested the component by temporarily replacing the MediaMap component with the new MediaVideo component in the pages/events/[id]/about.vue file. Please note that this replacement was done solely for testing purposes. I verified that the component integrates seamlessly and maintains consistent styling and sizing according to the design guidelines and tailwind configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 25, 2023

Thank you for the pull request!

The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local activist repo
  • The CHANGELOG has been updated with a description of the changes for the upcoming release (if necessary)

@netlify
Copy link

netlify bot commented Aug 25, 2023

Deploy Preview for activist-org ready!

Name Link
🔨 Latest commit 0a0532c
🔍 Latest deploy log https://app.netlify.com/sites/activist-org/deploys/64ea362f1bdfaf00083b4e1c
😎 Deploy Preview https://deploy-preview-299--activist-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@otaree otaree changed the title Initial implementation of baseline MediaVideo component with required… Feature: Initial implementation of baseline MediaVideo component with required link prop and styling Aug 25, 2023
@andrewtavis
Copy link
Member

Hey @otaree! Thanks for this commit 🙏 I'm realizing that there's an issue with your commit messages when doing the maintainer checklist. You'll notice that the user name and image don't match for the commit and the PR, so you won't get credit for your contribution.

Can you check the following as directed by the checklist:

If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local activist repo

@andrewtavis andrewtavis self-requested a review August 26, 2023 13:00
@otaree otaree force-pushed the feature/media-video-baseline branch from b69deb2 to e50e569 Compare August 26, 2023 13:44
@otaree
Copy link
Contributor Author

otaree commented Aug 26, 2023

Hey @andrewtavis, I've corrected it to match my GitHub email. This should ensure proper attribution of the contribution to my account. Thank you for your understanding.

@andrewtavis
Copy link
Member

No need for thanks, @otaree! Just trying to make sure you get your due credit, and trust me this happens all the time (henve the note for maintainers) 😊

<div
class="p-6 bg-light-special-text dark:bg-dark-menu-selection rounded-full"
>
<IconCameraVideo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only real comment I have on this @otaree is that I'm thinking we don't need a custom icon component for this. We can use a normal <Icon name='bi:camera-video' /> component or another one from Bootstrap Icons. We normally are making the custom icon components only in cases where we need to given that it's a branded icon or one we made specifically. We might event want to convert some of those custom icons over to ones available from Icones, which is something you'd be welcome to work on, @otaree!

Copy link
Member

@andrewtavis andrewtavis Aug 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can definitely see how you'd think that one would be necessary though, so no stress! Looking at it, IconJoin, IconLegal, and maybe a few others could be converted. Let me know if you'd have interest in this for another issue!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @andrewtavis , Thank you for your thoughtful insights and suggestions. I'm definitely interested in working on the conversion of the custom icons to standard ones, including "IconJoin" and "IconLegal." To keep things organized and clear, would you prefer that I create a separate pull request for this icon conversion task? This way, it won't mix with the changes in the current pull request, and we can focus on each aspect more effectively. Please let me know your thoughts on this approach, and I'll be more than happy to get started on making these improvements.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, @otaree, that'd be perfect if it was in a separate PR. Also, if you'd be so kind as to make an issue for this this would also be great 😊 I'd comment in there with any other information for it that's needed like how we'd need to update the legal docs if we use a new icon pack, but it'd be good to have an issue for an overview.

Appreciate your willingness to help!

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick reaction and changes on this, @otaree! Appreciate the work here and look forward to future contributions!

@andrewtavis andrewtavis merged commit 79fee63 into activist-org:main Aug 26, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants