refactor: use grid density seeding #2270
Conversation
github-actions
bot
added
Component - Core
Codecov Report
@@ Coverage Diff @@
## main #2270 +/- ##
=======================================
Coverage 49.27% 49.27%
=======================================
Files 449 449
Lines 25408 25408
Branches 11724 11724
=======================================
Hits 12521 12521
Misses 4554 4554
Partials 8333 8333
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
📊 Physics performance monitoring for c8f517aSummary VertexingVertexing vs. muIVF seededIVF truth_smearedIVF truth_estimatedIVF orthogonalAMVF seededAMVF truth_smearedAMVF truth_estimatedAMVF orthogonalSeedingSeeding seededSeeding truth_estimatedSeeding orthogonalCKFCKF seededCKF truth_smearedCKF truth_estimatedCKF orthogonalAmbiguity resolutionseededTruth tracking (Kalman Filter)Truth trackingTruth tracking (GSF)Truth tracking |
| @@ -15,6 +15,8 @@ | |||
| #include "Acts/Vertexing/Vertex.hpp" | |||
| #include "Acts/Vertexing/VertexingOptions.hpp" | |||
|
|
|||
| #include <map> | |||
| @@ -22,7 +22,8 @@ | |||
| #include "Acts/Vertexing/HelicalTrackLinearizer.hpp" | |||
| #include "Acts/Vertexing/ImpactPointEstimator.hpp" | |||
| #include "Acts/Vertexing/IterativeVertexFinder.hpp" | |||
| #include "Acts/Vertexing/TrackDensityVertexFinder.hpp" | |||
| //#include "Acts/Vertexing/TrackDensityVertexFinder.hpp" | |||
There was a problem hiding this comment.
please remove commented pieces of code
|
Hi @felix-russo I see there is the WIP label. Is this ready for review, or is it a draft PR? |
Hi @CarloVarni, no, this PR is not ready for review yet! I just wanted to know how the different seed finder affects the physics performance... I will look into this further and let you know when I am done! |
just to mention that you can also run physmon locally to check the performance, if you prefer |
|
Will investigate this later |
Replace gaussian vertex seeding (Sec. 5.4.2 in Bastian Schlag's thesis) with grid vertex seeding (Sec. 5.4.3 in Bastian Schlag's thesis)