Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use grid density seeding #2270

Closed
wants to merge 2 commits into from
Closed

refactor: use grid density seeding #2270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a97d241
use grid density seeding
felix-russo Jul 4, 2023
c8f517a
improve format
felix-russo Jul 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Core/include/Acts/Vertexing/GridDensityVertexFinder.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@
#include "Acts/Vertexing/Vertex.hpp"
#include "Acts/Vertexing/VertexingOptions.hpp"

#include <map>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this addition?


#include "DummyVertexFitter.hpp"

namespace Acts {
Expand Down
6 changes: 3 additions & 3 deletions ...es/Algorithms/Vertexing/include/ActsExamples/Vertexing/IterativeVertexFinderAlgorithm.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@
#include "Acts/Vertexing/HelicalTrackLinearizer.hpp"
#include "Acts/Vertexing/ImpactPointEstimator.hpp"
#include "Acts/Vertexing/IterativeVertexFinder.hpp"
#include "Acts/Vertexing/TrackDensityVertexFinder.hpp"
//#include "Acts/Vertexing/TrackDensityVertexFinder.hpp"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove commented pieces of code

#include "Acts/Vertexing/GridDensityVertexFinder.hpp"
#include "Acts/Vertexing/Vertex.hpp"
#include "Acts/Vertexing/VertexingOptions.hpp"
#include "ActsExamples/EventData/ProtoVertex.hpp"
Expand Down Expand Up @@ -57,8 +58,7 @@ class IterativeVertexFinderAlgorithm final : public IAlgorithm {
using Linearizer = Acts::HelicalTrackLinearizer<Propagator>;
using Fitter =
Acts::FullBilloirVertexFitter<Acts::BoundTrackParameters, Linearizer>;
using Seeder = Acts::TrackDensityVertexFinder<
Fitter, Acts::GaussianTrackDensity<Acts::BoundTrackParameters>>;
using Seeder = Acts::GridDensityVertexFinder<2000, 15, Fitter>;
using Finder = Acts::IterativeVertexFinder<Fitter, Seeder>;
using Options = Acts::VertexingOptions<Acts::BoundTrackParameters>;

Expand Down