No-eta for CommAlgebras #1130
Closed
No-eta for CommAlgebras #1130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixwellen
force-pushed
the
fwellen/no-eta-comm-algebra
branch
3 times, most recently
from
da6ed74
to
6c77a13
Compare
felixwellen
force-pushed
the
fwellen/no-eta-comm-algebra
branch
from
6c77a13
to
11c6f4d
Compare
felixwellen
force-pushed
the
fwellen/no-eta-comm-algebra
branch
from
11c6f4d
to
51cacff
Compare
|
tc speed seems to be only minimally affected: Cubical.AlgebraicGeometry.ZariskiLattice.StructureSheafPullback check a bit more than a second faster and I didn't see anything with a bigger change. |
|
It might make more of a difference to have no-eta for Algebras (because e.g. type checking CommAlgebra-homomorphism compositions should actually be about Algebras being equal...) |
felixwellen
force-pushed
the
fwellen/no-eta-comm-algebra
branch
from
51cacff
to
9c3a53e
Compare
felixwellen
force-pushed
the
fwellen/no-eta-comm-algebra
branch
from
9c3a53e
to
ff57972
Compare
|
obsoleted by #1145 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just an experiment to see if it helps with tc speed when CommAlgbras have no eta law.