-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add first set of sea maps #388
Conversation
It is indeed correct to include the Joseph Bonaparte Gulf. I would perhaps just pan to the West a little.
Very slight discrepancy with IHO: the western limit should go around the little island North of Norway:
How about panning to the West a little, so Southeast Asia and the Philippines are a bit more visible? Also, I feel like the eastern limit is a tiny, tiny bit off -- it should pass a bit East of one of the small islands:
Maybe pan to the East a tiny bit? Regarding the limits, there are quite a few subtle differences with the IHO:
Those are all really minor details, so I'm not fussed if they're too hard to fix. 😉 They look awesome already 💯 |
Thanks for the very detailed feedback! Timor SeaPanned slightly west. East China SeaPanning changed Yellow SeaI've also changed it, since it probably should have the same panning as the East China Sea (and IMO it looks better now, compared to how I had previously panned it...). OldNewNorth SeaPanning and some of the limits changed. Not applied (yet?)
(They're generally trickier, since they require the adjusting of the shapefiles, which I'm relatively hesitant to do, since doing it fully correctly is tricky, while doing it just-about-good-enough is still relatively time consuming, but feels "wrong" (I trust the shapefiles from Natural Earth Data to represent something, while I don't quite trust my own shapefiles which would neither be NE, nor quite IHO 2002 ones... However, for some of the other cases where the discrepancies are greater, I might need to edit shapefiles, anyway, so if I get "into the swing of things" I might come back to some of these. (I've used my own shapefiles for the Bering Strait, and it wasn't that bad.) If I do, then some of the other maps (e.g. the Norwegian Sea, which borders both the Barents Sea and the North Sea) might need to be updated, as well.) |
No pressure, these are great as they are and already tremendously beneficial to the deck! 💯 |
I'm going to move all the tiny discrepancies that require modifying the shapefile into a separate issue. Let's get all those beautiful maps merged in, shall we!? |
Oh right, So my point is: happy to merge all your maps in their current state whenever you're ready. I'll open up the issue with the discrepancies once the PR is merged. |
I think I'm done (with this set of maps). For review purposes I've added the English, German, Spanish and French translations but none of the others. I'm ignoring the French name variation "Golfe de l'Alaska", as being similar to the main variant and the old German name "Meerbusen von Guinea" since quickly googling it, the only non-Wiki results appear to be colonial-era maps. I haven't updated the counts in Generation scripts updated! |
These are the ones that didn't seem to differ from the IHO 2002 maps at all. src/data and sources not changed yet.
It makes it easier to add new entries: just add them to the end and then run: LC_ALL=C sort < sources.csv | sponge sources.csv (Ugh, I hate that this is locale-dependent and that, say, libreoffice sorts in a yet another, very slightly different way, with denmark after denmark_strait. My sorting this way isn't intended to be prescriptive for others, I just don't want to look for the alphabetical place to insert several new entries, but do want to distinguish the content changes from the sorting changes.) Also apply quote normalisation: csvtool cols 1- sources.csv | sponge sources.csv
I'm ignoring the French name variation "Golfe de l'Alaska", as being similar to the main variant and the old German name "Meerbusen von Guinea" since quickly googling it, the only non-Wiki results appear to be colonial-era maps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
I've added the remaining translations. A few of the article titles on Russian Wikipedia follow the homonymy scheme - e.g. Alaska (gulf), so I had to make some adjustments.
I think it's better to have potentially incorrect translations than no translations at all, as it's easier to fix something that exists than to realise that something is missing. That being said, I didn't look at alternative names at all, they're above my pay grade :D
Wow! Thanks! You're right that some translation is better than no translation. I wish we had a way of marking translations as "to be reviewed". OTOH by the law of the internet the best way to get an answer is to make a (potentially incorrect) statement, so we'll probably get feedback anyway. :) |
The minor insconsistencies with the IHO are now documented in a discussion thread: #412 |
(For release notes: part of #386 + panning of the Yellow Sea map)
These are the ones that didn't seem to differ from the IHO 2002 maps at all. Many others differ very slightly (e.g. one of the limits is from the northern rather than the southern end of an island...).
src/data
andsources.csv
not changed yet.Please feel leave feedback regarding panning/zooming in etc.! (Panning/zooming is easy to change!)
Banda Sea
http://wiki.geosys.ru/lib/exe/fetch.php/ru/portal/lib/iho/s23.los.ed4draft.2002.pdf#page=135
Barents Sea
http://wiki.geosys.ru/lib/exe/fetch.php/ru/portal/lib/iho/s23.los.ed4draft.2002.pdf#page=205
Celebes Sea
http://wiki.geosys.ru/lib/exe/fetch.php/ru/portal/lib/iho/s23.los.ed4draft.2002.pdf#page=147
East China Sea
http://wiki.geosys.ru/lib/exe/fetch.php/ru/portal/lib/iho/s23.los.ed4draft.2002.pdf#page=162
Possibly zoom in? (But the context is more important and zooming in more won't really provide much value. Compare the Yellow Sea and the South China Sea.
Gulf of Alaska
http://wiki.geosys.ru/lib/exe/fetch.php/ru/portal/lib/iho/s23.los.ed4draft.2002.pdf#page=176
Gulf of Guinea
http://wiki.geosys.ru/lib/exe/fetch.php/ru/portal/lib/iho/s23.los.ed4draft.2002.pdf#page=25
North Sea
http://wiki.geosys.ru/lib/exe/fetch.php/ru/portal/lib/iho/s23.los.ed4draft.2002.pdf#page=16
Northern limit?
Sea of Okhotsk
http://wiki.geosys.ru/lib/exe/fetch.php/ru/portal/lib/iho/s23.los.ed4draft.2002.pdf#page=171
Timor Sea
http://wiki.geosys.ru/lib/exe/fetch.php/ru/portal/lib/iho/s23.los.ed4draft.2002.pdf#page=98
(Includes Joseph Bonaparte Gulf, but I think that that's correct.)