Add first set of sea maps #388

aplaice · 2021-02-06T13:59:31Z

(For release notes: part of #386 + panning of the Yellow Sea map)

These are the ones that didn't seem to differ from the IHO 2002 maps at all. Many others differ very slightly (e.g. one of the limits is from the northern rather than the southern end of an island...).

src/data and sources.csv not changed yet.

Please feel leave feedback regarding panning/zooming in etc.! (Panning/zooming is easy to change!)

Banda Sea

http://wiki.geosys.ru/lib/exe/fetch.php/ru/portal/lib/iho/s23.los.ed4draft.2002.pdf#page=135

Barents Sea

http://wiki.geosys.ru/lib/exe/fetch.php/ru/portal/lib/iho/s23.los.ed4draft.2002.pdf#page=205

Celebes Sea

http://wiki.geosys.ru/lib/exe/fetch.php/ru/portal/lib/iho/s23.los.ed4draft.2002.pdf#page=147

East China Sea

http://wiki.geosys.ru/lib/exe/fetch.php/ru/portal/lib/iho/s23.los.ed4draft.2002.pdf#page=162

Possibly zoom in? (But the context is more important and zooming in more won't really provide much value. Compare the Yellow Sea and the South China Sea.

Gulf of Alaska

http://wiki.geosys.ru/lib/exe/fetch.php/ru/portal/lib/iho/s23.los.ed4draft.2002.pdf#page=176

Gulf of Guinea

http://wiki.geosys.ru/lib/exe/fetch.php/ru/portal/lib/iho/s23.los.ed4draft.2002.pdf#page=25

North Sea

http://wiki.geosys.ru/lib/exe/fetch.php/ru/portal/lib/iho/s23.los.ed4draft.2002.pdf#page=16

Northern limit?

Sea of Okhotsk

http://wiki.geosys.ru/lib/exe/fetch.php/ru/portal/lib/iho/s23.los.ed4draft.2002.pdf#page=171

Timor Sea

http://wiki.geosys.ru/lib/exe/fetch.php/ru/portal/lib/iho/s23.los.ed4draft.2002.pdf#page=98

(Includes Joseph Bonaparte Gulf, but I think that that's correct.)

axelboc · 2021-02-06T19:01:39Z

Banda Sea ✔️
Celebes Sea ✔️
Gulf of Alaska ✔️
Gulf of Guinea ✔️
Sea of Okhotsk ✔️
Timor Sea

It is indeed correct to include the Joseph Bonaparte Gulf. I would perhaps just pan to the West a little.

Barents Sea

Very slight discrepancy with IHO: the western limit should go around the little island North of Norway:

East China Sea

How about panning to the West a little, so Southeast Asia and the Philippines are a bit more visible? Also, I feel like the eastern limit is a tiny, tiny bit off -- it should pass a bit East of one of the small islands:

North Sea

Maybe pan to the East a tiny bit? Regarding the limits, there are quite a few subtle differences with the IHO:

Northwest limit should be a straight line between the two islands instead of curving to the tiny island in the middle:

Northern limit should start at the tip of the northern most island):

Northeastern limit should include both fjords:

Waterways in the tip of Denmark should not be included:

Southern limit should go past the chain of islands up to the entrance of the main bay of the Netherlands:

... and should not include the other bay near Belgium:

Those are all really minor details, so I'm not fussed if they're too hard to fix. 😉 They look awesome already 💯

aplaice · 2021-02-07T15:36:20Z

Thanks for the very detailed feedback!

Timor Sea

Panned slightly west.

East China Sea

Panning changed

Yellow Sea

I've also changed it, since it probably should have the same panning as the East China Sea (and IMO it looks better now, compared to how I had previously panned it...).

Old

New

North Sea

Panning and some of the limits changed.

Not applied (yet?)

Barents Sea (western limit)
East China Sea (eastern limit)
North Sea (northwest limit)
North Sea (northern limit)
North Sea (waterways in the tip of Denmark)
North Sea (bay near Belgium)

(They're generally trickier, since they require the adjusting of the shapefiles, which I'm relatively hesitant to do, since doing it fully correctly is tricky, while doing it just-about-good-enough is still relatively time consuming, but feels "wrong" (I trust the shapefiles from Natural Earth Data to represent something, while I don't quite trust my own shapefiles which would neither be NE, nor quite IHO 2002 ones...

However, for some of the other cases where the discrepancies are greater, I might need to edit shapefiles, anyway, so if I get "into the swing of things" I might come back to some of these. (I've used my own shapefiles for the Bering Strait, and it wasn't that bad.)

If I do, then some of the other maps (e.g. the Norwegian Sea, which borders both the Barents Sea and the North Sea) might need to be updated, as well.)

axelboc · 2021-02-07T18:11:21Z

No pressure, these are great as they are and already tremendously beneficial to the deck! 💯

axelboc · 2021-03-16T14:30:35Z

I'm going to move all the tiny discrepancies that require modifying the shapefile into a separate issue. Let's get all those beautiful maps merged in, shall we!?

axelboc · 2021-03-16T14:37:31Z

Oh right, src/data and sources.csv still need to be updated, sorry. (Though for the sources, you can put TBC or something for now, I reckon.)

So my point is: happy to merge all your maps in their current state whenever you're ready. I'll open up the issue with the discrepancies once the PR is merged.

aplaice · 2021-04-05T15:25:41Z

I think I'm done (with this set of maps). For review purposes 395d10c is the master-rebased version of the previous last commit.

I've added the English, German, Spanish and French translations but none of the others.

I'm ignoring the French name variation "Golfe de l'Alaska", as being similar to the main variant and the old German name "Meerbusen von Guinea" since quickly googling it, the only non-Wiki results appear to be colonial-era maps.

I haven't updated the counts in README.md since it's probably best to do it all in one go, but FWIW the number of notes and maps has increased by 9!

Generation scripts updated!

These are the ones that didn't seem to differ from the IHO 2002 maps at all. src/data and sources not changed yet.

It makes it easier to add new entries: just add them to the end and then run: LC_ALL=C sort < sources.csv | sponge sources.csv (Ugh, I hate that this is locale-dependent and that, say, libreoffice sorts in a yet another, very slightly different way, with denmark after denmark_strait. My sorting this way isn't intended to be prescriptive for others, I just don't want to look for the alphabetical place to insert several new entries, but do want to distinguish the content changes from the sorting changes.) Also apply quote normalisation: csvtool cols 1- sources.csv | sponge sources.csv

I'm ignoring the French name variation "Golfe de l'Alaska", as being similar to the main variant and the old German name "Meerbusen von Guinea" since quickly googling it, the only non-Wiki results appear to be colonial-era maps.

axelboc

Awesome!

I've added the remaining translations. A few of the article titles on Russian Wikipedia follow the homonymy scheme - e.g. Alaska (gulf), so I had to make some adjustments.

I think it's better to have potentially incorrect translations than no translations at all, as it's easier to fix something that exists than to realise that something is missing. That being said, I didn't look at alternative names at all, they're above my pay grade :D

aplaice · 2021-04-10T13:33:25Z

I've added the remaining translations.

Wow! Thanks! You're right that some translation is better than no translation.

I wish we had a way of marking translations as "to be reviewed". OTOH by the law of the internet the best way to get an answer is to make a (potentially incorrect) statement, so we'll probably get feedback anyway. :)

axelboc · 2021-04-10T13:36:30Z

The minor insconsistencies with the IHO are now documented in a discussion thread: #412

aplaice marked this pull request as draft February 6, 2021 14:01

aplaice force-pushed the more_seas branch from 8c1d557 to 6089251 Compare April 5, 2021 15:19

aplaice marked this pull request as ready for review April 5, 2021 15:27

aplaice force-pushed the more_seas branch from e686758 to 3baf128 Compare April 5, 2021 15:38

aplaice added 6 commits April 10, 2021 11:30

Add first set of sea maps

1062b0b

These are the ones that didn't seem to differ from the IHO 2002 maps at all. src/data and sources not changed yet.

Apply (partially) @axelboc's feedback

987531c

Mention new sea maps in sources

3b44204

Add new seas to src/data/

1ae7b6e

I'm ignoring the French name variation "Golfe de l'Alaska", as being similar to the main variant and the old German name "Meerbusen von Guinea" since quickly googling it, the only non-Wiki results appear to be colonial-era maps.

Add GUIDs

6757dac

axelboc added the content Content changes, map improvements, translation fixes, etc. label Apr 10, 2021

axelboc added this to the v4.2 milestone Apr 10, 2021

axelboc force-pushed the more_seas branch from 3baf128 to 6757dac Compare April 10, 2021 09:48

Add remaining translations for new sea maps

a4f2ade

axelboc approved these changes Apr 10, 2021

View reviewed changes

axelboc merged commit 6402d12 into anki-geo:master Apr 10, 2021

axelboc mentioned this pull request Apr 10, 2021

Add more seas with maps #386

Open

35 tasks

aplaice deleted the more_seas branch December 21, 2023 21:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add first set of sea maps #388

Add first set of sea maps #388

aplaice commented Feb 6, 2021 •

edited by axelboc

Loading

axelboc commented Feb 6, 2021

aplaice commented Feb 7, 2021 •

edited

Loading

axelboc commented Feb 7, 2021

axelboc commented Mar 16, 2021

axelboc commented Mar 16, 2021

aplaice commented Apr 5, 2021 •

edited

Loading

axelboc left a comment •

edited

Loading

aplaice commented Apr 10, 2021

axelboc commented Apr 10, 2021

Add first set of sea maps #388

Add first set of sea maps #388

Conversation

aplaice commented Feb 6, 2021 • edited by axelboc Loading

Banda Sea

Barents Sea

Celebes Sea

East China Sea

Gulf of Alaska

Gulf of Guinea

North Sea

Sea of Okhotsk

Timor Sea

axelboc commented Feb 6, 2021

aplaice commented Feb 7, 2021 • edited Loading

Timor Sea

East China Sea

Yellow Sea

Old

New

North Sea

Not applied (yet?)

axelboc commented Feb 7, 2021

axelboc commented Mar 16, 2021

axelboc commented Mar 16, 2021

aplaice commented Apr 5, 2021 • edited Loading

axelboc left a comment • edited Loading

Choose a reason for hiding this comment

aplaice commented Apr 10, 2021

axelboc commented Apr 10, 2021

aplaice commented Feb 6, 2021 •

edited by axelboc

Loading

aplaice commented Feb 7, 2021 •

edited

Loading

aplaice commented Apr 5, 2021 •

edited

Loading

axelboc left a comment •

edited

Loading