Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add first set of sea maps #388

Merged
merged 7 commits into from
Apr 10, 2021
Merged

Add first set of sea maps #388

merged 7 commits into from
Apr 10, 2021

Commits on Apr 10, 2021

  1. Add first set of sea maps 

    These are the ones that didn't seem to differ from the IHO 2002 maps
at all.

src/data and sources not changed yet.
    @aplaice @axelboc
    aplaice authored and axelboc committed Apr 10, 2021
    Configuration menu
    Copy the full SHA
    1062b0b View commit details
    Browse the repository at this point in the history

  2. Apply (partially) @axelboc's feedback

    @aplaice @axelboc
    aplaice authored and axelboc committed Apr 10, 2021
    Configuration menu
    Copy the full SHA
    987531c View commit details
    Browse the repository at this point in the history

  3. Resort sources.csv 

    It makes it easier to add new entries: just add them to the end and
then run:

LC_ALL=C sort < sources.csv | sponge sources.csv

(Ugh, I hate that this is locale-dependent and that, say, libreoffice
sorts in a yet another, very slightly different way, with denmark
after denmark_strait.  My sorting this way isn't intended to be
prescriptive for others, I just don't want to look for the
alphabetical place
to insert several new entries, but do want to distinguish the content
changes from the sorting changes.)

Also apply quote normalisation:

csvtool cols 1- sources.csv | sponge sources.csv
    @aplaice @axelboc
    aplaice authored and axelboc committed Apr 10, 2021
    Configuration menu
    Copy the full SHA
    e0d190f View commit details
    Browse the repository at this point in the history

  4. Mention new sea maps in sources

    @aplaice @axelboc
    aplaice authored and axelboc committed Apr 10, 2021
    Configuration menu
    Copy the full SHA
    3b44204 View commit details
    Browse the repository at this point in the history

  5. Add new seas to src/data/ 

    I'm ignoring the French name variation "Golfe de l'Alaska", as being
similar to the main variant and the old German name "Meerbusen von
Guinea" since quickly googling it, the only non-Wiki results appear to
be colonial-era maps.
    @aplaice @axelboc
    aplaice authored and axelboc committed Apr 10, 2021
    Configuration menu
    Copy the full SHA
    1ae7b6e View commit details
    Browse the repository at this point in the history

  6. Add GUIDs

    @aplaice @axelboc
    aplaice authored and axelboc committed Apr 10, 2021
    Configuration menu
    Copy the full SHA
    6757dac View commit details
    Browse the repository at this point in the history

  7. Add remaining translations for new sea maps

    @axelboc
    axelboc committed Apr 10, 2021
    Configuration menu
    Copy the full SHA
    a4f2ade View commit details
    Browse the repository at this point in the history