Import modal - add !pipeline filter #4016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
backport-4.7
himdel
force-pushed
the
import-modal-pipeline
branch
from
744229f
to
f640104
Compare
add filter, no need to use fixed repos to filter approved/rejected out now also switch to AnsibleRepositoryAPI - no need to rewrite sort & ordering don't expect to get the full list of repositories => only use loadAllRepos for repaint and preselect, => no select all => use selected counts for deselect No-Issue
himdel
force-pushed
the
import-modal-pipeline
branch
from
f640104
to
9b2e12f
Compare
himdel
force-pushed
the
import-modal-pipeline
branch
from
c08879f
to
23a8abd
Compare
himdel
force-pushed
the
import-modal-pipeline
branch
from
3700775
to
95d9246
Compare
himdel
force-pushed
the
import-modal-pipeline
branch
from
95d9246
to
111ce65
Compare
Backport to stable-4.7: 💚 backport PR created✅ Backport PR branch: Backported as #4164 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Aug 31, 2023
* Import modal - add !pipeline filter add filter, no need to use fixed repos to filter approved/rejected out now also switch to AnsibleRepositoryAPI - no need to rewrite sort & ordering don't expect to get the full list of repositories => only use loadAllRepos for repaint and preselect, => no select all => use selected counts for deselect No-Issue * repo selector table - use <td> for individual fields * tests: select all is gone, deselect all shows actual selected count * click N more before testing labels (cherry picked from commit 07a1c1c)
himdel
added a commit
that referenced
this pull request
Sep 1, 2023
* Import modal - add !pipeline filter add filter, no need to use fixed repos to filter approved/rejected out now also switch to AnsibleRepositoryAPI - no need to rewrite sort & ordering don't expect to get the full list of repositories => only use loadAllRepos for repaint and preselect, => no select all => use selected counts for deselect No-Issue * repo selector table - use <td> for individual fields * tests: select all is gone, deselect all shows actual selected count * click N more before testing labels (cherry picked from commit 07a1c1c) Co-authored-by: Martin Hradil <mhradil@redhat.com>
github-actions
bot
added
the
backported-4.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add filter, no need to use fixed repos to filter approved/rejected out now
don't expect to get the full list of repositories
=> only use loadAllRepos for repaint and preselect,
=> no select all
=> use selected counts for deselect