[PR #4016/07a1c1cd backport][stable-4.7] Import modal - add !pipeline filter #4164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
* Import modal - add !pipeline filter add filter, no need to use fixed repos to filter approved/rejected out now also switch to AnsibleRepositoryAPI - no need to rewrite sort & ordering don't expect to get the full list of repositories => only use loadAllRepos for repaint and preselect, => no select all => use selected counts for deselect No-Issue * repo selector table - use <td> for individual fields * tests: select all is gone, deselect all shows actual selected count * click N more before testing labels (cherry picked from commit 07a1c1c)
|
Can one of the admins verify this patch? |
himdel
deleted the
patchback/backports/stable-4.7/07a1c1cd45e400969c1990df435d7523589ae2af/pr-4016
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #4016 as merged into master (07a1c1c).
add filter, no need to use fixed repos to filter approved/rejected out now
don't expect to get the full list of repositories
=> only use loadAllRepos for repaint and preselect,
=> no select all
=> use selected counts for deselect