Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention toolchains limitations in docs #672

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mfussenegger
Copy link

If forkCount is configured the test goal can fail with a
UnsupportedClassVersionError

Apparently this is by design:

https://issues.apache.org/jira/browse/SUREFIRE-720?focusedCommentId=16395576&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16395576

The documentation should mention a limitation like that.

If forkCount is configured the test goal can fail with a
UnsupportedClassVersionError

Apparently this is by design:

    https://issues.apache.org/jira/browse/SUREFIRE-720?focusedCommentId=16395576&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16395576

The documentation should mention a limitation like that.
Comment on lines +39 to +41
Note that options like <<<forkCount>>> prevent the toolchains from being used.
See {{{https://issues.apache.org/jira/browse/SUREFIRE-720}}SUREFIRE-720} for more information.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of pointing issue - I would like to see description how forkCount option impact on toolchains.
Reading issue and all comments is not easy to find clue of problem.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't

Note that options like <<>> prevent the toolchains from being used.

describing the impact?

I'm not familiar with the exact details why it is not working. If you expect that then someone else has to make the changes.

I'd think this is at least an improvement over the status quo, because currently it says that surefire picks up toolchains by default, while it doesn't if forkCount is set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants