Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention toolchains limitations in docs #672

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Mention toolchains limitations in docs #672

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions maven-surefire-plugin/src/site/apt/examples/toolchains.apt.vm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@ Using Maven Toolchains with ${thisPlugin}.
guide, ${thisPlugin} will launch the test jvm using the main toolchain
configured in Maven.

Note that options like <<<forkCount>>> prevent the toolchains from being used.
See {{{https://issues.apache.org/jira/browse/SUREFIRE-720}}SUREFIRE-720} for more information.

Comment on lines +39 to +41
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of pointing issue - I would like to see description how forkCount option impact on toolchains.
Reading issue and all comments is not easy to find clue of problem.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't

Note that options like <<>> prevent the toolchains from being used.

describing the impact?

I'm not familiar with the exact details why it is not working. If you expect that then someone else has to make the changes.

I'd think this is at least an improvement over the status quo, because currently it says that surefire picks up toolchains by default, while it doesn't if forkCount is set.

In some cases, it may be desirable to compile and test using different jvms.
While the <<<jvm>>> option can achieve this, it requires hardcoding system-specific paths.
Configuration option <<<jdkToolchain>>> can be used to supply an alternate toolchain specification.
Expand Down