Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LEM circuit cleanup #689

Merged
merged 4 commits into from
Sep 19, 2023
Merged

LEM circuit cleanup #689

merged 4 commits into from
Sep 19, 2023

Conversation

gabriel-barrett
Copy link
Member

This PR makes lem/circuit.rs a bit more clean. Removes unnecessary functions in favour of already defined functions (like AllocatedNum::alloc and AllocatedPtr::alloc), removes unnecessary mutable borrows (some gadgets require a mut cs so there's no sense in sending a &mut cs), and makes namespaces more minimal

arthurpaulino
arthurpaulino previously approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@arthurpaulino arthurpaulino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I left a few minor comments. Nothing blocking

src/lem/circuit.rs Outdated Show resolved Hide resolved
src/lem/circuit.rs Outdated Show resolved Hide resolved
@arthurpaulino arthurpaulino added this pull request to the merge queue Sep 19, 2023
Merged via the queue into master with commit c91cc59 Sep 19, 2023
6 checks passed
@arthurpaulino arthurpaulino deleted the lem-circuit-simplify branch September 19, 2023 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmorais emmorais emmorais approved these changes

@arthurpaulino arthurpaulino arthurpaulino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gabriel-barrett @arthurpaulino @emmorais