Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LEM circuit cleanup #689

Merged
merged 4 commits into from
Sep 19, 2023
Merged

LEM circuit cleanup #689

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cba8f1a
Removed unnecessary functions in lem/circuit.rs
gabriel-barrett Sep 19, 2023
07b3682
Removed unnecessary mutable borrows and annotations
gabriel-barrett Sep 19, 2023
75a0049
Better namespaces
gabriel-barrett Sep 19, 2023
060b8bf
`alloc_infallible`
gabriel-barrett Sep 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/circuit/gadgets/pointer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ use crate::{
store::Store,
tag::{ExprTag, Tag},
writer::Write,
z_ptr::{ZContPtr, ZExprPtr},
z_ptr::{ZContPtr, ZExprPtr, ZPtr},
};

use super::{
Expand Down Expand Up @@ -53,12 +53,12 @@ impl<F: LurkField> Debug for AllocatedPtr<F> {
}

impl<F: LurkField> AllocatedPtr<F> {
pub fn alloc<Fo, CS: ConstraintSystem<F>>(
pub fn alloc<Fo, CS: ConstraintSystem<F>, T: Tag>(
cs: &mut CS,
value: Fo,
) -> Result<Self, SynthesisError>
where
Fo: FnOnce() -> Result<ZExprPtr<F>, SynthesisError>,
Fo: FnOnce() -> Result<ZPtr<T, F>, SynthesisError>,
{
let mut hash = None;
let alloc_tag = AllocatedNum::alloc(&mut cs.namespace(|| "tag"), || {
Expand Down
Loading
Loading