Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove dead code from multiple modules (easy) #828

Merged
merged 1 commit into from
Nov 1, 2023

Commits on Nov 1, 2023

  1. chore: remove dead code from multiple modules

    - Removed redundant and unused functions across multiple files including `hash_witness.rs`, `z_data/z_store.rs`, `eval/mod.rs`, and `symbol.rs`.
    
    Remaining unused items are in the following categories:
    - in a module we don't want to touch today (argumentcomputer#804), and where removal needs some thought, e.g. `parse_code`, `parse_space`, `parse_line_comment`, `assert_all_paths_taken`, `construct`, `construct_strcons`,
    - small utilities which removal wouldn't be significant, e.g. `is_evaluation`, `is_root_symbol`, `push_tag`, `push_symbol`, `push_default`, `to_z_expr`, `is_coprocessor`
    - related to underused functionality we know we'll want to extend the use of:
        - supernova (`supernova_circuit_params`, `supernova_aux_params`, `supernova_public_params`),
        - opaque pointers (`intern_maybe_opaque_fun`, `intern_maybe_opaque_sym`, `hidden`, `get_opaque_ptr`, `new_opaque_pr`, ...)
        - public parameter caching (`circuit_cache_key`, `with_public_params`)
    huitseeker committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    f82a5e5 View commit details
    Browse the repository at this point in the history