chore:: Refactor field tests to use pasta_curves instead of blstrs #845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Follow-up of argumentcomputer#774 - Swapped out `blstrs::Scalar` implementation in `src/field.rs` with pasta_curves::pallas::Scalar - Readjusted tests to now run on the `pasta_curve` as opposed to the `blstrs` - Updated `Cargo.toml` by removing `blstrs` from both the workspace and dev dependencies - Removed the association of `blstrs/portable` from the `portable` feature in `Cargo.toml`
|
Some benchmarks mention the wrong field name, referring to BLS12 instead of Vesta. Should we change it here? |
- Removed `BLS12_381` option across the project, affecting the enumeration of `LanguageField`, use in `src/lem/circuit.rs`, and representation in `src/cli/mod.rs`. - Updated test and benchmarking data in `src/field.rs` and `end2end_lem.rs` to reflect these changes. - Reestructured `src/cli/circom.rs` directory for simplicity and updated the logic generating `r1cs` and `witness`. - Removed "bls" feature from neptune in Cargo.toml, and updated documentation in README.md to reflect these changes.
arthurpaulino
approved these changes
Nov 3, 2023
samuelburnham
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
blstrs::Scalarimplementation insrc/field.rswith pasta_curves::pallas::Scalarpasta_curveas opposed to theblstrsCargo.tomlby removingblstrsfrom both the workspace and dev dependenciesblstrs/portablefrom theportablefeature inCargo.toml