Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore:: Refactor field tests to use pasta_curves instead of blstrs #845

Merged
merged 2 commits into from
Nov 3, 2023
Merged

chore:: Refactor field tests to use pasta_curves instead of blstrs #845

merged 2 commits into from
Nov 3, 2023

Commits on Nov 3, 2023

  1. chore:: Refactor field tests to use pasta_curves instead of blstrs 

    - Follow-up of argumentcomputer#774
- Swapped out `blstrs::Scalar` implementation in `src/field.rs` with pasta_curves::pallas::Scalar
- Readjusted tests to now run on the `pasta_curve` as opposed to the `blstrs`
- Updated `Cargo.toml` by removing `blstrs` from both the workspace and dev dependencies
- Removed the association of `blstrs/portable` from the `portable` feature in `Cargo.toml`
    @huitseeker
    huitseeker committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    3af471c View commit details
    Browse the repository at this point in the history

  2. refactor: Remove BLS12-381 support from the LanguageField enum 

    - Removed `BLS12_381` option across the project, affecting the enumeration of `LanguageField`, use in `src/lem/circuit.rs`, and representation in `src/cli/mod.rs`.
- Updated test and benchmarking data in `src/field.rs` and `end2end_lem.rs` to reflect these changes.
- Reestructured  `src/cli/circom.rs` directory for simplicity and updated the logic generating `r1cs` and `witness`.
- Removed "bls" feature from neptune in Cargo.toml, and updated documentation in README.md to reflect these changes.
    @huitseeker
    huitseeker committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    e0206a7 View commit details
    Browse the repository at this point in the history