Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.4.2 #168

Merged
merged 238 commits into from
Jun 15, 2019
Merged

Release v1.4.2 #168

merged 238 commits into from
Jun 15, 2019

Conversation

argenos
Copy link
Contributor

@argenos argenos commented May 25, 2019

Changelog

Enhancements

  • Add Kaldi as the default speech recognition engine
  • Adds the following maps:
    • German Open Arena
    • Rheinbach
  • Add "Find my mates" robocup scenario
    • Add the find people action
    • Add interview person behaviour
    • Add describe person behaviour
  • General improvements on "Where is this" scenario
  • move_arm_action
    • Replaced the DMP service call with an API call
    • All DMP parameters are now configurable

Fixes

  • General clean up of new robocup scenarios
  • Move NLU and speech models to mas_models
  • Update dependency to mas_navigation_tools
  • Adds dependency to [ros_dmp](https://github.com/b-it-bots/ros_dmp) for mas_move_arm_action`
  • All navigation goals are now lower case to follow convention

robertocaiwu and others added 30 commits May 1, 2019 15:00
This commit adds a first version of the "find my mates scenario of the RoboCup @home league 2019. Additionally an action for interviewing people is added. Also here it is not the final version.
Add the "find_my_mates" scenario and "interview action".
add classify image as an optional param
Apperently a merge conflict was in the code and that is fixed with this commit.
This commit provides a comphrehensive version of the "Find my mate" scenario. A few more information need to be added though. For example location values.
…thers.

At the moment the following behaviours are needed that are defined in the "Find my mate" scenario.
@argenos
Copy link
Contributor Author

argenos commented Jun 8, 2019

@alex-mitrevski @PatrickNa what is missing to merge this? Could you make your reviews please?

@alex-mitrevski
Copy link
Member

There are at least a couple of open comments that should be resolved before we merge (e.g. an HSR-specific topic being hard-coded or incorrect model paths being specified).

mdr_environments/go-2019/map.yaml Outdated Show resolved Hide resolved
@@ -0,0 +1,2 @@
model_checkpoint_path: "/home/patrick/rasa/models/current/nlu/intent_classifier_tensorflow_embedding.ckpt"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of this file anyway?

@@ -0,0 +1,97 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not all this model data go into mas_models?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I thought there was a PR for this already.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no PR, but there is an issue (#171) which is assigned to you, could you move them there when you get the chance?

@@ -0,0 +1,259 @@
senbei
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It depends. Sometimes you want to compare the recognized speech to a specific list of objects... Generating it from the ontology fills the list with words that are not of interest.

@argenos
Copy link
Contributor Author

argenos commented Jun 11, 2019

To clarify the missing to-dos, please correct me if there's something missing :

argenos and others added 8 commits June 12, 2019 09:14
Instead of checking matches in two hard coded text files. The algorithm now loops over all files specified in the config directory. Additionally dependencies in the package.xml have been clarified and unnecessary comments removed. TODO: change the type of the msg of this package.
@argenos argenos requested a review from PatrickNa June 15, 2019 10:15
…ehaviors_models

Moving mdr_hri_behaviours nlu model to mas_models
@argenos
Copy link
Contributor Author

argenos commented Jun 15, 2019

@alex-mitrevski @PatrickNa checks are passing and final changes were just merged, could you please review/approve so I can merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.