feat: expose a flag name for allow_unresolved_symlinks #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows a principled solution for rules like rules_js that need to have starlark logic conditional on the value, without a breaking change in Bazel 7 as the flag has been renamed. Unblocks aspect-build/rules_js#1102 Alternative to #14
|
Since we may need to add more flag names in the future, how about moving this into a new |
|
Yes, thanks I didn't look closely enough at the existing structure of the file, fixed. |
alexeagle
force-pushed
the
allow_unresolved_symlinks2
branch
from
dd247de
to
ebacf3e
Compare
alexeagle
force-pushed
the
allow_unresolved_symlinks2
branch
from
ebacf3e
to
d20b88f
Compare
fmeum
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows a principled solution for rules like rules_js that need to have starlark logic conditional on the value, without a breaking change in Bazel 7 as the flag has been renamed.
Unblocks aspect-build/rules_js#1102
Alternative to #14