Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expose a flag name for allow_unresolved_symlinks #15

Merged
merged 3 commits into from
Jul 27, 2023
Merged

feat: expose a flag name for allow_unresolved_symlinks #15

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
acfd97d
feat: expose a flag name for allow_unresolved_symlinks
alexeagle Jul 27, 2023
d20b88f
code review comments
alexeagle Jul 27, 2023
16bbc66
fix: be precise about which 7.0 release changes the flag name
alexeagle Jul 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions features.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,15 @@ _external_deps = struct(
is_bzlmod_enabled = str(Label("//:invalid")).startswith("@@"),
)

_flags = struct(
# This flag was renamed in https://github.com/bazelbuild/bazel/pull/18313
allow_unresolved_symlinks = (
"allow_unresolved_symlinks"
if ge("7.0.0-pre.20230628.2")
else "experimental_allow_unresolved_symlinks"
)
)

_rules = struct(
# Whether TemplateDict#add_joined allows the map_each callback to return a list of strings (#17306)
template_dict_map_each_can_return_list = ge("6.1.0"),
Expand All @@ -30,6 +39,7 @@ _toolchains = struct(
bazel_features = struct(
cc = _cc,
external_deps = _external_deps,
flags = _flags,
globals = globals,
rules = _rules,
toolchains = _toolchains,
Expand Down