-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --incompatible_no_implicit_watch_label
#23750
Conversation
When the flag is flipped, `ctx.path` no longer watches paths. It used to do so for `Label` arguments only, which is inconsistent with how the other `ctx` methods operate now that they also watch files.
@fmeum should we include this in |
@bazel-io fork 7.4.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe add a shell integration test, with the flag on and off?
src/main/java/com/google/devtools/build/lib/packages/semantics/BuildLanguageOptions.java
Outdated
Show resolved
Hide resolved
...ava/com/google/devtools/build/lib/bazel/repository/starlark/StarlarkBaseExternalContext.java
Outdated
Show resolved
Hide resolved
...ava/com/google/devtools/build/lib/bazel/repository/starlark/StarlarkBaseExternalContext.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Xùdōng Yáng <wyverald@gmail.com>
656b046
to
a0d26f2
Compare
Can you file an incompatible change issue to document this flag? |
@meteorcloudy I created #23861. |
When the flag is flipped, `ctx.path` no longer watches paths resolved from `Label` parameters and other methods on `ctx` no longer watch such paths even with `watch = "no"`. Closes bazelbuild#23750. PiperOrigin-RevId: 681978073 Change-Id: I9bef5c735db54c971beb806aa1f1a0eb287e3ff2 (cherry picked from commit 5019697)
When the flag is flipped, `ctx.path` no longer watches paths resolved from `Label` parameters and other methods on `ctx` no longer watch such paths even with `watch = "no"`. Closes #23750. PiperOrigin-RevId: 681978073 Change-Id: I9bef5c735db54c971beb806aa1f1a0eb287e3ff2 (cherry picked from commit 5019697) Closes #23768
The changes in this PR have been included in Bazel 7.4.0 RC1. Please test out the release candidate and report any issues as soon as possible. |
When the flag is flipped,
ctx.path
no longer watches paths resolved fromLabel
parameters and other methods onctx
no longer watch such paths even withwatch = "no"
.