Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flip --incompatible_no_implicit_watch_label #23872

Closed
wants to merge 1 commit into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Oct 4, 2024

Fixes #23861

RELNOTES[inc]: repository_ctx.path() and module_ctx.path() no longer watch arguments of type Label. Use the watch() method or the watch parameter on other methods on these context objects instead. See #23861 for details.

@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Oct 4, 2024
@meteorcloudy meteorcloudy added the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Oct 4, 2024
RELNOTES[inc]: `repository_ctx.path()` and `module_ctx.path()` no longer watch arguments of type `Label`. Use the `watch()` method or the `watch` parameter on other methods on these context objects instead. See bazelbuild#23861 for details.
@fmeum
Copy link
Collaborator Author

fmeum commented Oct 4, 2024

I fixed the test

@Wyverald Wyverald removed the awaiting-review PR is awaiting review from an assigned reviewer label Oct 4, 2024
@copybara-service copybara-service bot closed this in 527ab48 Oct 4, 2024
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Oct 4, 2024
@fmeum fmeum deleted the flip-watch branch October 4, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--incompatible_no_implicit_watch_label
3 participants