Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flip --incompatible_no_implicit_watch_label #23872

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ public final class BuildLanguageOptions extends OptionsBase {

@Option(
name = "incompatible_no_implicit_watch_label",
defaultValue = "false",
defaultValue = "true",
documentationCategory = OptionDocumentationCategory.STARLARK_SEMANTICS,
metadataTags = OptionMetadataTag.INCOMPATIBLE_CHANGE,
effectTags = OptionEffectTag.LOADING_AND_ANALYSIS,
Expand Down Expand Up @@ -963,7 +963,7 @@ public StarlarkSemantics toStarlarkSemantics() {
public static final String EXPERIMENTAL_ISOLATED_EXTENSION_USAGES =
"-experimental_isolated_extension_usages";
public static final String INCOMPATIBLE_NO_IMPLICIT_WATCH_LABEL =
"-incompatible_no_implicit_watch_label";
"+incompatible_no_implicit_watch_label";
public static final String EXPERIMENTAL_GOOGLE_LEGACY_API = "-experimental_google_legacy_api";
public static final String EXPERIMENTAL_PLATFORMS_API = "-experimental_platforms_api";
public static final String EXPERIMENTAL_REPO_REMOTE_EXEC = "-experimental_repo_remote_exec";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -516,7 +516,11 @@ public void testWorkspaceRoot() throws Exception {

@Test
public void testNoIncompatibleNoImplicitWatchLabel() throws Exception {
setUpContextForRule("test");
setUpContextForRule(
"test",
StarlarkSemantics.DEFAULT.toBuilder()
.setBool(BuildLanguageOptions.INCOMPATIBLE_NO_IMPLICIT_WATCH_LABEL, false)
.build());
scratch.file(root.getRelative("foo").getPathString());
StarlarkPath unusedPath = context.getPath(fakeFileLabel);
String unusedRead = context.readFile(fakeFileLabel, "no", thread);
Expand Down
Loading