Merge pull request #291 from bdaiinstitute/fix-checks

fix dumb syntax issue
bdaiinstitute · Aug 23, 2024 · d71d26b · d71d26b
2 parents ccaa689 + c6f3718
commit d71d26b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/predicators/approaches/maple_q_approach.py b/predicators/approaches/maple_q_approach.py
@@ -176,7 +176,7 @@ def _learn_nsrts(self, trajectories: List[LowLevelTrajectory],
         if (online_learning_cycle is None or len(
                 self._q_function._ordered_ground_nsrts) + len(  # pylint: disable=protected-access
                     self._q_function._ordered_frozen_goals) + len(  # pylint: disable=protected-access
-                        self._q_function._ordered_objects) == 0) and
+                        self._q_function._ordered_objects) == 0) and \
             CFG.approach != "rl_bridge_policy":  # pylint: disable=protected-access
             all_ground_nsrts: Set[_GroundNSRT] = set()
             if CFG.sesame_grounder == "naive":

diff --git a/predicators/structs.py b/predicators/structs.py
@@ -182,9 +182,11 @@ def allclose(self, other: State) -> bool:
         objects are the same, and the features are close."""
         if self.simulator_state is not None or \
            other.simulator_state is not None:
-          if not CFG.allow_state_allclose_comparison_despite_simulator_state:
+            if not CFG.allow_state_allclose_comparison_despite_simulator_state:
                 raise NotImplementedError("Cannot use allclose when "
                                           "simulator_state is not None.")
+            if self.simulator_state != other.simulator_state:
+                return False
         return self._allclose(other)
 
     def _allclose(self, other: State) -> bool: