Merge with upstream #283
Merged
Merge with upstream #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g-and-Intelligent-Systems#1616) * should be good to go! * feedback
…-and-Intelligent-Systems#1619) * adds new flag to deactivate pruned grammar * initial euclidean distance grammar implementation * add command line flags * need to modify stick button to contain movement options * adds nsrts and options correctly! * oracle works for new stick_button env! * gets debug grammar mostly working! 37/50! * good to go * revert ipdb * lots of type and linting fixes * remove cov files * all tests * fixes linting * fixes tests and other things * adds new predicate to get 50/50 with debug grammar! * rerun OG predicators experiments * OG gets 41/40 * adds new predicates and operators to get oracle to 50/50! * revert * good to go hopefully! * isort * fixes tests! * revert bad changes
…Intelligent-Systems#1627) * Initial commit. * Fix HandEmpty predicate to only use the robot's state. * Get tests to pass. * Differentiate press from pickplace in action space and fix tests. * Add holder to PlaceStick option's arguments and get tests to pass. * Get tests to pass. * Remove old commented code. * Add test to improve coverage for PlaceStick related code. * Add tests to fix coverage. * Add newline to end of test file. * Run autoformatter. * Fix test. * Fix test. * Update comment about collision with stick holder.
…ystems#1632) * ready to go! * tom comments * yapf
…ligent-Systems#1633) * init commit * good to go! Just need to address @aathalye's comment * ready for prime time! * yapf * tom feedback
…Systems/predicators into merge-with-upstream
NishanthJKumar
requested review from
nkumar-bdai,
wmcclinton and
tsilver-bdai
as code owners
nkumar-bdai
approved these changes
Apr 29, 2024
|
Great!! 👍 Thanks for merging upstream VLM changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly want to include all the VLM changes!