-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pre-commit config and clear errors #12
Conversation
Thanks @jiuguangw ! Looks great - why is this happening though?
|
This is the reason I put up the other Docker PR - the dependencies are too complex to rely on GitHub Actions to install by itself. I consolidated all the relevant packages into a pre-built Docker, which will solve the spacing issue here as well as reduce build time by 90%. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can make the environment and run it with no issues if I add in the changes I needed to do to get Naoki's code to run. I will add these changes as a separate pull request.
I did get this error when doing the pre-commit stuff but it still seems to work ok:
vlfm/vlm/grounding_dino.py:64: error: Incompatible types in assignment (expression has type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
My pre-commit wasn't working because I had installed frontier_exploration by manually cloning it and installing inside this repo locally, which results in ruff changing the way it should be ordered when importing it with other packages at the top of a Python script. So when I linted it locally, it would be different from when it was linted in the CI |
e8fd079
to
0c466b1
Compare
Explain mypy / the use of it our repo to Katrina - she's fixing mypy errors for her local changes. |
bdai
repochmod -x
on a few files with shebang but not marked as executableWith these changes, I believe
vlfm
can now be merged intobdai
with a trivialgit subtree add --prefix projects/vlfm https://github.com/bdaiinstitute/vlfm main --squash