Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pre-commit config and clear errors #12

Merged
merged 3 commits into from
Oct 16, 2023
Merged

Conversation

jiuguangw
Copy link
Collaborator

  • Updated pre-commit config to match bdai repo
  • Did chmod -x on a few files with shebang but not marked as executable
  • Various other auto-formatting. There was something wrong with @naokiyokoyama 's local setup and his pre-commit was never fully able to clear CI.

With these changes, I believe vlfm can now be merged into bdai with a trivial

git subtree add --prefix projects/vlfm https://github.com/bdaiinstitute/vlfm main --squash

@bernadettekb
Copy link
Contributor

Thanks @jiuguangw ! Looks great - why is this happening though?

ERROR: Could not install packages due to an OSError: [Errno 28] No space left on device

@jiuguangw
Copy link
Collaborator Author

Thanks @jiuguangw ! Looks great - why is this happening though?

ERROR: Could not install packages due to an OSError: [Errno 28] No space left on device

This is the reason I put up the other Docker PR - the dependencies are too complex to rely on GitHub Actions to install by itself. I consolidated all the relevant packages into a pre-built Docker, which will solve the spacing issue here as well as reduce build time by 90%.

Copy link
Contributor

@kashton-bdai kashton-bdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can make the environment and run it with no issues if I add in the changes I needed to do to get Naoki's code to run. I will add these changes as a separate pull request.

@kashton-bdai
Copy link
Contributor

I did get this error when doing the pre-commit stuff but it still seems to work ok:
mypy.....................................................................Failed

  • hook id: mypy
  • exit code: 1

vlfm/vlm/grounding_dino.py:64: error: Incompatible types in assignment (expression has type
"Optional[str]", variable has type "str") [assignment]

Copy link
Collaborator

@naokiyokoyama naokiyokoyama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@naokiyokoyama
Copy link
Collaborator

My pre-commit wasn't working because I had installed frontier_exploration by manually cloning it and installing inside this repo locally, which results in ruff changing the way it should be ordered when importing it with other packages at the top of a Python script. So when I linted it locally, it would be different from when it was linted in the CI

@jiuguangw jiuguangw merged commit 0e82142 into main Oct 16, 2023
2 checks passed
@jiuguangw jiuguangw deleted the jw/fix_precommit branch October 16, 2023 15:06
@bernadettekb
Copy link
Contributor

I did get this error when doing the pre-commit stuff but it still seems to work ok: mypy.....................................................................Failed

  • hook id: mypy
  • exit code: 1

vlfm/vlm/grounding_dino.py:64: error: Incompatible types in assignment (expression has type "Optional[str]", variable has type "str") [assignment]

Explain mypy / the use of it our repo to Katrina - she's fixing mypy errors for her local changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants