Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dockerfile for VLFM #13

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Add Dockerfile for VLFM #13

merged 1 commit into from
Oct 16, 2023

Conversation

jiuguangw
Copy link
Collaborator

@jiuguangw jiuguangw commented Oct 15, 2023

  • Add Dockerfile to pre-build the various dependencies
  • Updated CI workflow use the new Docker image

Right now the main build still fails as the image has not been pushed to the GitHub Container Registry yet.

@jiuguangw jiuguangw force-pushed the jw/docker branch 10 times, most recently from 7893d90 to d04f152 Compare October 15, 2023 04:19
@jiuguangw jiuguangw marked this pull request as ready for review October 15, 2023 04:23
@jiuguangw jiuguangw force-pushed the jw/docker branch 2 times, most recently from f604abf to 4f4fc39 Compare October 16, 2023 00:50
Copy link
Contributor

@bernadettekb bernadettekb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks @jiuguangw !

@jiuguangw jiuguangw merged commit 3cc486e into main Oct 16, 2023
1 of 3 checks passed
@jiuguangw jiuguangw deleted the jw/docker branch October 16, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants