Fix corruption when running cargo test on ARM64 #693
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run `cargo test` on ARM64 will encounter following corruption, which is caused by unaligned memory access. So enable the test for x86_64 only. thread 'coredump::test::test_coredump' panicked at src/coredump.rs:94:30: misaligned pointer dereference: address must be a multiple of 0x8 but is 0xffffa6ba0334 note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace thread caused non-unwinding panic. aborting. error: test failed, to rerun pass `--lib` Caused by: process didn't exit successfully: `/dragonball/py-spy.git/target/debug/deps/py_spy-1a1c8047c3d9ee13` (signal: 6, SIGABRT: process abort signal) Signed-off-by: Jiang Liu <gerry@linux.alibaba.com>
zanieb
reviewed
Oct 12, 2024
| #[cfg(test)] | ||
| mod test { | ||
| use super::*; | ||
| use py_spy_testdata::get_coredump_path; | ||
|
|
||
| #[cfg(target_pointer_width = "64")] |
There was a problem hiding this comment.
Why was this inner cfg insufficient?
There was a problem hiding this comment.
ARM64 will also match this cfg, but it seems that the coredump file is generated from x86 thus cause unaligned access on ARM64.
|
Does #657 fix the issue for you? |
|
Prefer #657 instead of this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run
cargo teston ARM64 will encounter following corruption, which is caused by unaligned memory access. So enable the test for x86_64 only.thread 'coredump::test::test_coredump' panicked at src/coredump.rs:94:30: misaligned pointer dereference: address must be a multiple of 0x8 but is 0xffffa6ba0334 note: run with
RUST_BACKTRACE=1environment variable to display a backtrace thread caused non-unwinding panic. aborting.error: test failed, to rerun pass
--libCaused by:
process didn't exit successfully:
/dragonball/py-spy.git/target/debug/deps/py_spy-1a1c8047c3d9ee13(signal: 6, SIGABRT: process abort signal)