Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix corruption when running cargo test on ARM64 #693

Closed
wants to merge 1 commit into from
Closed

Fix corruption when running cargo test on ARM64 #693

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/coredump.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,12 +429,12 @@ mod elfcore {
}
}

#[cfg(target_arch = "x86_64")]
#[cfg(test)]
mod test {
use super::*;
use py_spy_testdata::get_coredump_path;

#[cfg(target_pointer_width = "64")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this inner cfg insufficient?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ARM64 will also match this cfg, but it seems that the coredump file is generated from x86 thus cause unaligned access on ARM64.

#[test]
fn test_coredump() {
// we won't have the python binary for the core dump here,
Expand Down
Loading