Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional sampling #13

Merged
merged 171 commits into from
Jan 23, 2024
Merged

Conditional sampling #13

merged 171 commits into from
Jan 23, 2024

Conversation

mnwright
Copy link
Member

@mnwright mnwright commented Dec 1, 2023

Implements conditional sampling.

This is the version started by @dswatson that we want to merge into main.

@mnwright
Copy link
Member Author

mnwright commented Jan 4, 2024

It seems we have a problem with alpha > 0:

arf <- adversarial_rf(iris)
psi <- forde(arf, iris, alpha = 0.01)
# Error in psi_cat_fn(tree) :
# task 1 failed - "Elements listed in `by` must be valid column names in x and y"

This happens since this commit: d45cf14

@dswatson
Copy link
Collaborator

dswatson commented Jan 4, 2024

I am unable to reproduce this error in the current version of this branch.

@mnwright
Copy link
Member Author

mnwright commented Jan 5, 2024

Added a test and that also fails. I'll try to debug later.

@mnwright
Copy link
Member Author

mnwright commented Jan 5, 2024

Should be fixed now.

@mnwright mnwright merged commit d85ee73 into main Jan 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants