-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/keycloak] use hostname v2 options #28611
Conversation
Keep in mind #28121 is still open/broken. I presume this change will have impact for some users as we don't fully control how hostnames/urls are constructed causing broken behaviour in setups with wildcards or path suffixes like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes LGTM. Just a couple of things:
- Bump a minor version (22.1.0) since it adds a new value
- Check DCO for all the commits
Good catch, done and done. Waiting for bitnami/containers#70466... |
Signed-off-by: Baljit Singh <baljit.singh@verizon.com>
Rebased, and ready to merge |
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Description of the change
Use Hostname v2 options as v1 options are not used by default.
Benefits
Use updated configurations in alignment with upstream Keycloak project.
Possible drawbacks
Enabling hostname-strict when hostname is more secure, but may cause issues for some users.
Applicable issues
Additional information
This has be merged after the image is updated, see bitnami/containers#70466.
Checklist
Chart.yaml
according to semver. This is not necessary when the changes only affect README.md files.README.md
using readme-generator-for-helm