Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/keycloak] use hostname v2 options #28611

Merged
merged 3 commits into from
Aug 6, 2024
Merged

Conversation

singhbaljit
Copy link
Contributor

@singhbaljit singhbaljit commented Jul 31, 2024

Description of the change

Use Hostname v2 options as v1 options are not used by default.

Benefits

Use updated configurations in alignment with upstream Keycloak project.

Possible drawbacks

Enabling hostname-strict when hostname is more secure, but may cause issues for some users.

Applicable issues

Additional information

This has be merged after the image is updated, see bitnami/containers#70466.

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@djas19
Copy link

djas19 commented Aug 1, 2024

Keep in mind #28121 is still open/broken. I presume this change will have impact for some users as we don't fully control how hostnames/urls are constructed causing broken behaviour in setups with wildcards or path suffixes like httpRelativePath

@singhbaljit
Copy link
Contributor Author

@djas19 this is only focusing on option name change, to avoid making this PR too complicated. proxy is deprecated anyways; so I think we should focus on removing it instead. I've opened a related issue as well, #28590.

Copy link
Member

@dgomezleon dgomezleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes LGTM. Just a couple of things:

  • Bump a minor version (22.1.0) since it adds a new value
  • Check DCO for all the commits

@singhbaljit
Copy link
Contributor Author

Good catch, done and done. Waiting for bitnami/containers#70466...

Signed-off-by: Baljit Singh <baljit.singh@verizon.com>
@singhbaljit
Copy link
Contributor Author

Rebased, and ready to merge

Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
@dgomezleon dgomezleon enabled auto-merge (squash) August 6, 2024 15:58
@dgomezleon dgomezleon merged commit 559b860 into bitnami:main Aug 6, 2024
11 checks passed
@singhbaljit singhbaljit deleted the kc25 branch August 6, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keycloak solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[binamit/keycloak] Helm chart using deprecated hostname v1 env variable
5 participants