[bitnami/keycloak] add variables to support hostname v2

[singhbaljit]

Description of the change

Use Hostname v2 options as v1 options are not used by default.

Benefits

Use updated configurations in alignment with upstream Keycloak project.

Possible drawbacks

KEYCLOAK_HOSTNAME variable is the same between v1 and v2 option; however, its usage is slightly different in v2. User may not realize the change and expect the same behavior as v1.

Applicable issues

• fixes [bitnami/keycloak] Use Hostname v2 in Keycloak v25 images #70461

Additional information

PR to use the options in the chart: bitnami/charts#28611.

[singhbaljit]

I added support for two additional variables: KEYCLOAK_HOSTNAME_ADMIN and KEYCLOAK_HOSTNAME_STRICT with the same defaults as before. The chart will have to be updated to override the defaults based on ingress configs.

[dgomezleon]

Hi @singhbaljit ,

Please note that the logic is shared for both branches 24 and 25, so you should apply it for version 24 too. I don't see any risk in doing that since the default values did not change.
Could you please check it?

[singhbaljit]

The variable names are the same, but their meaning is a little different in v24 (hostname v1) vs. v25 (hostname v2), namely hostname vs. hostname URL. The chart wants to specify the full URL, and it does so by using the v1 URL variables, bypassing these variables altogether. In other words, these variables won't be used in v24. They will be used in v25 after bitnami/charts#28611 is merged. But I can certainly add it if consistency is preferred.

[singhbaljit]

@dgomezleon I updated v24 scripts as well.

[dgomezleon]

Thanks @singhbaljit

LGTM. Could you please check the conflicts?

[singhbaljit]

The conflict is due to the fact that v24 is now removed 😄, see #70607 . So, I'll just undo the v24 changes.

[dgomezleon]

The conflict is due to the fact that v24 is now removed 😄, see #70607 . So, I'll just undo the v24 changes.

Just today :). Sorry for the noise.