[bitnami/valkey-sentinel] Update tests to check the master to primary change in the configuration #74090
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… change in the configuration Signed-off-by: Jota Martos <jotamartos@vmware.com>
carrodher
previously approved these changes
Oct 31, 2024
Signed-off-by: Jota Martos <jotamartos@vmware.com>
jotamartos
commented
Oct 31, 2024
| # Remove if sentinel gets updated: https://github.com/valkey-io/valkey/blob/7.2/sentinel.conf | ||
| check-primary-master-change: | ||
| exec: if [ $(grep "SENTINEL \(master-reboot-down-after-period\|primary-reboot-down-after-period\)" /tmp/sentinel.conf | wc -l) -gt 1 ]; then exit 1; fi | ||
| exit-status: 0 | ||
| check-valkey-server: |
There was a problem hiding this comment.
This test shouldn't be working. Checking why it succeeded
valkey-sentinel-1 | valkey-sentinel 15:58:19.88 INFO ==> ** Starting Valkey Sentinel **
valkey-sentinel-1 |
valkey-sentinel-1 | *** FATAL CONFIG FILE ERROR (Version 7.2.7) ***
valkey-sentinel-1 | Reading the configuration file, at line 358
valkey-sentinel-1 | >>> 'SENTINEL master-reboot-down-after-period mymaster 0'
valkey-sentinel-1 | No such master with specified name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Add test to validate we are not adding both parameters to the configuration
Benefits
Will find errors like this one earlier
#74017
Possible drawbacks
None
Additional information
This test simply checks that we do not accidentally add both conf parameters to the conf file