Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bitnami/valkey-sentinel] Update tests to check the master to primary change in the configuration #74090

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −0
Open

[bitnami/valkey-sentinel] Update tests to check the master to primary change in the configuration #74090

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0babe9b
[bitnami/valkey-sentinel] Update tests to check the master to primary…
jotamartos Oct 31, 2024
63c2433
[bitnami/valkey-sentinel] Fix file path
jotamartos Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .vib/valkey-sentinel/goss/valkey-sentinel.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ file:
- "daemonize no"
- 'logfile ""'
command:
# Remove if sentinel gets updated: https://github.com/valkey-io/valkey/blob/7.2/sentinel.conf
check-primary-master-change:
exec: if [ $(grep "SENTINEL \(master-reboot-down-after-period\|primary-reboot-down-after-period\)" /opt/bitnami/valkey-sentinel/etc/sentinel.conf | wc -l) -gt 1 ]; then exit 1; fi
exit-status: 0
check-valkey-server:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test shouldn't be working. Checking why it succeeded

valkey-sentinel-1  | valkey-sentinel 15:58:19.88 INFO  ==> ** Starting Valkey Sentinel **
valkey-sentinel-1  | 
valkey-sentinel-1  | *** FATAL CONFIG FILE ERROR (Version 7.2.7) ***
valkey-sentinel-1  | Reading the configuration file, at line 358
valkey-sentinel-1  | >>> 'SENTINEL master-reboot-down-after-period mymaster 0'
valkey-sentinel-1  | No such master with specified name.

exec: timeout --preserve-status 5 valkey-server /opt/bitnami/valkey-sentinel/etc/sentinel.conf --sentinel
exit-status: 0
Expand Down
Loading