Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add browser table release changelog entry #166

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Add browser table release changelog entry #166

merged 1 commit into from
Aug 29, 2024

Conversation

rileyhgrant
Copy link
Contributor

@rileyhgrant rileyhgrant commented Aug 9, 2024 •
edited
Loading

@rileyhgrant
Copy link
Contributor Author

rileyhgrant commented Aug 9, 2024 •
edited
Loading

Related: #165, broadinstitute/gnomad-browser#1583

This is an example of using the newly renamed decap cms to create a new changelog entry. This changelog entry will be reformatted and polished up shortly, to accompany the release of the gnomAD browser Hail Tables. For now, this PR is just serving as a sanity check that Decap acts in the same way Netlify did, and still fills our needs.

@rileyhgrant rileyhgrant force-pushed the cms/changelog/2024-08-release-gnomad-browser-tables branch from ad21e82 to 1d80ffe Compare August 20, 2024 17:04
@rileyhgrant rileyhgrant self-assigned this Aug 20, 2024
@rileyhgrant rileyhgrant force-pushed the cms/changelog/2024-08-release-gnomad-browser-tables branch from 07ef872 to 6841e70 Compare August 20, 2024 17:42
@rileyhgrant rileyhgrant mentioned this pull request Aug 20, 2024
Merged
@rileyhgrant rileyhgrant requested a review from ch-kr August 20, 2024 19:38
ch-kr
ch-kr reviewed Aug 21, 2024
View reviewed changes
Copy link
Contributor

@ch-kr ch-kr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the links -- super handy! just few minor comments to increase clarity

content/changelog/2024-08-release-gnomad-browser-tables.md Outdated Show resolved Hide resolved
content/changelog/2024-08-release-gnomad-browser-tables.md Outdated Show resolved Hide resolved
content/changelog/2024-08-release-gnomad-browser-tables.md Outdated Show resolved Hide resolved
content/changelog/2024-08-release-gnomad-browser-tables.md Outdated Show resolved Hide resolved
content/changelog/2024-08-release-gnomad-browser-tables.md Outdated Show resolved Hide resolved
content/changelog/2024-08-release-gnomad-browser-tables.md Outdated Show resolved Hide resolved
mattsolo1
mattsolo1 approved these changes Aug 28, 2024
View reviewed changes
content/changelog/2024-08-release-gnomad-browser-tables.md Outdated
@@ -0,0 +1,28 @@
---
title: Release gnomAD browser tables
date: 2024-08-20
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update date

@rileyhgrant rileyhgrant force-pushed the cms/changelog/2024-08-release-gnomad-browser-tables branch from 12a06cf to dd969f3 Compare August 28, 2024 20:18
@rileyhgrant rileyhgrant changed the title Create Changelog “2024-08-release-gnomad-browser-tables” Add browser table release changelog entry Aug 28, 2024
@rileyhgrant rileyhgrant merged commit 2f29980 into main Aug 29, 2024
5 checks passed
@rileyhgrant rileyhgrant deleted the cms/changelog/2024-08-release-gnomad-browser-tables branch August 29, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ch-kr ch-kr ch-kr left review comments

@mattsolo1 mattsolo1 mattsolo1 approved these changes

Assignees

@rileyhgrant rileyhgrant

Labels
decap-cms/draft
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rileyhgrant @mattsolo1 @ch-kr