Render fafs of 0 as '-' character on variant pages #1646
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, our variant pipeline took the
faf
array, took the relevant genetic ancestry group's filtered AFs from this array, filtered out all the entries of this smaller list where the faf was 0, then took the max of this array to render as the "Grpmax filtering AF (95% confidence)".With v4, the step that filtered out entries from this reduced array with a faf of 0 was mistakenly dropped. This led to the fafmax for a given variant being possible to be 0, where it was previously not able to be. In these cases, the methods team calls the fafmax for these variants as missing, rather than 0.
This PR does two small things
This achieves both a quick fix that does not require a variant reload, and fixes the problem more systematically when the v4 variants pipeline is next rerun.