Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preview: send a first preview after exectution of the command #456

Merged
merged 1 commit into from
May 4, 2023

Conversation

paulRbr
Copy link
Member

@paulRbr paulRbr commented May 4, 2023

With the preview --live command we used to wait for some changes on
the target file before launching the preview.

With this PR we generate a first preview with the given file, THEN
wait for future changes on the file.

About #182

With the `preview --live` command we used to wait for some changes on
the target file before launching the preview.

With this PR we generate a first preview with the given file, THEN
wait for future changes on the file.

About bump-sh#182
Copy link
Member

@scharrier scharrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this small (but great!) enhancement 🙇

@paulRbr paulRbr merged commit bc0db07 into bump-sh:main May 4, 2023
@paulRbr paulRbr deleted the live-preview branch May 9, 2023 10:27
paulRbr added a commit to paulRbr/cli that referenced this pull request Oct 5, 2023
This commit makes sure to only create one preview (the previous
tentative fix on live previews would create 1 preview, then a 2nd
preview, and then update that 2nd preview).

Follow-up to bump-sh#456 (cf bump-sh#182)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants