Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: to allow connector/flow steps to interchange behaviours in the flow #473

Draft
wants to merge 13 commits into
base: MOODLE_35_STABLE
Choose a base branch
from

Commits on Aug 5, 2022

  1. Configuration menu
    Copy the full SHA
    51c543c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7f21659 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    29440e0 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c37e29c View commit details
    Browse the repository at this point in the history
  5. wip: flip the check in the connector engine step because iterator-esq…

    …ue steps no longer return true. Instead they should explicitly return false when things go bad.
    keevan committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    d76b6d8 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    26b8970 View commit details
    Browse the repository at this point in the history
  7. the magic: if the step type is resolved to a flow, then it is a flow …

    …step, otherwise it is a connector step.
    
    We can now use this alongside config to determine which type it is. Certain step types will be fixed (so they cannot change) e.g. readers, writers?
    keevan committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    7dbffb9 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2022

  1. Configuration menu
    Copy the full SHA
    cf43319 View commit details
    Browse the repository at this point in the history
  2. add connector flag in steps table, update dot graph handling to visua…

    …lly display this change and fix side effect flags
    keevan committed Aug 6, 2022
    Configuration menu
    Copy the full SHA
    4cf3979 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    dc4ca2e View commit details
    Browse the repository at this point in the history
  4. For connector-like steps, the input isn't real and so should be an em…

    …pty object.
    
    Thinking about removing this entirely actually, since the input is irrelevant in most cases unless it needs to be altered
    keevan committed Aug 6, 2022
    Configuration menu
    Copy the full SHA
    e084bb7 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    9ed4442 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    3964748 View commit details
    Browse the repository at this point in the history