-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: to allow connector/flow steps to interchange behaviours in the flow #473
Draft
keevan
wants to merge
13
commits into
MOODLE_35_STABLE
Choose a base branch
from
422-i-give-you-permission-to
base: MOODLE_35_STABLE
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ue steps no longer return true. Instead they should explicitly return false when things go bad.
…step, otherwise it is a connector step. We can now use this alongside config to determine which type it is. Certain step types will be fixed (so they cannot change) e.g. readers, writers?
…lly display this change and fix side effect flags
…pty object. Thinking about removing this entirely actually, since the input is irrelevant in most cases unless it needs to be altered
keevan
changed the title
422 i give you permission to
refactor to allow connector/flow steps to interchange behaviours in the flow
Aug 8, 2022
keevan
changed the title
refactor to allow connector/flow steps to interchange behaviours in the flow
refactor: to allow connector/flow steps to interchange behaviours in the flow
Aug 8, 2022
Open
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prooof of concept sprinkled with some cleanup along the way:
Example workflow:
new_dual_curl_step_20220806_0802.yml.txt
Related to #422