Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: to allow connector/flow steps to interchange behaviours in the flow #473

Draft
wants to merge 13 commits into
base: MOODLE_35_STABLE
Choose a base branch
from

Conversation

keevan
Copy link
Contributor

@keevan keevan commented Aug 6, 2022

  • feat: fill in name of new steps based on step type
  • [wip] feat: flow and connector steps can now be used interchangably
  • wip: add curl step with dual step support
  • wip: adjust curl step, add helper methods to ease authoring
  • wip: flip the check in the connector engine step because iterator-esque steps no longer return true. Instead they should explicitly return false when things go bad.
  • everybody needs variables, even connectors
  • the magic: if the step type is resolved to a flow, then it is a flow step, otherwise it is a connector step.
  • refactor: simplify generate_engine_step methods for flow/connector steps
  • add connector flag in steps table, update dot graph handling to visually display this change and fix side effect flags
  • fix: step chooser / new step form (side quest)
  • For connector-like steps, the input isn't real and so should be an empty object.
  • changed curl_step to curl, updated handling of prefilled names for new steps
  • fix weird issue where has_side_effect wouldn't enter probably magic getters

Prooof of concept sprinkled with some cleanup along the way:
image

Example workflow:
new_dual_curl_step_20220806_0802.yml.txt

Related to #422

@keevan keevan changed the title 422 i give you permission to refactor to allow connector/flow steps to interchange behaviours in the flow Aug 8, 2022
@keevan keevan changed the title refactor to allow connector/flow steps to interchange behaviours in the flow refactor: to allow connector/flow steps to interchange behaviours in the flow Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow a step to be both a connector and a flow step and dynamically change depending on config
1 participant