-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add binding list to workspaces api #375
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I left a few comments though.
Co-authored-by: Alexey Kazakov <alkazako@redhat.com>
Co-authored-by: Alexey Kazakov <alkazako@redhat.com>
Co-authored-by: Alexey Kazakov <alkazako@redhat.com>
Co-authored-by: Alexey Kazakov <alkazako@redhat.com>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@alexeykazakov @rajivnathan thanks for your review! I've addressed your comments, PTAL when you have time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Description
Add list of bindings to the current workspace API.
See jira: https://issues.redhat.com/browse/ASC-409
Checks
Did you run
make generate
target? yesDid
make generate
change anything in other projects (member-operator)? yesIn case of new CRD, did you the following? N/A
In case other projects are changed, please provides PR links.