Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add binding list to workspaces api #472

Merged
merged 5 commits into from
Sep 18, 2023
Merged

feat: add binding list to workspaces api #472

merged 5 commits into from
Sep 18, 2023

Conversation

mfrancisc
Copy link
Contributor

@mfrancisc mfrancisc mentioned this pull request Sep 11, 2023
Merged
@codecov
Copy link

codecov bot commented Sep 11, 2023 •
edited
Loading

Codecov Report

Merging #472 (2598d78) into master (45b8946) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #472   +/-   ##
=======================================
  Coverage   82.02%   82.02%           
=======================================
  Files          30       30           
  Lines        3444     3444           
=======================================
  Hits         2825     2825           
  Misses        474      474           
  Partials      145      145

@openshift-ci
Copy link

openshift-ci bot commented Sep 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, mfrancisc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rajivnathan
Copy link
Contributor

/retest

@sonarcloud
Copy link

sonarcloud bot commented Sep 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mfrancisc
Copy link
Contributor Author

/retest

Flaky ? https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/codeready-toolchain_member-operator/472/pull-ci-codeready-toolchain-member-operator-master-e2e/1703860008703234048

@alexeykazakov
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 18, 2023
@openshift-merge-robot openshift-merge-robot merged commit 451186e into codeready-toolchain:master Sep 18, 2023
14 checks passed
@mfrancisc mfrancisc deleted the sbapi branch September 20, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeykazakov alexeykazakov alexeykazakov approved these changes

@sbryzak sbryzak Awaiting requested review from sbryzak

@xcoulon xcoulon Awaiting requested review from xcoulon xcoulon is a code owner

@MatousJobanek MatousJobanek Awaiting requested review from MatousJobanek MatousJobanek is a code owner

@rajivnathan rajivnathan Awaiting requested review from rajivnathan rajivnathan is a code owner

@ranakan19 ranakan19 Awaiting requested review from ranakan19 ranakan19 is a code owner

Assignees

@alexeykazakov alexeykazakov

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mfrancisc @rajivnathan @alexeykazakov @openshift-merge-robot