KUBESAW-192: Introduce a make command for pre-requisite of verify-replace #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lace Signed-off-by: Feny Mehta <fbm3307@gmail.com>
fbm3307
requested review from
MatousJobanek,
xcoulon,
alexeykazakov,
rajivnathan,
ranakan19,
sbryzak and
mfrancisc
as code owners
This was referenced Sep 24, 2024
mfrancisc
approved these changes
Sep 24, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #599 +/- ##
=======================================
Coverage 83.56% 83.56%
=======================================
Files 28 28
Lines 2604 2604
=======================================
Hits 2176 2176
Misses 288 288
Partials 140 140 |
MatousJobanek
approved these changes
Sep 25, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fbm3307, MatousJobanek, mfrancisc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a make command for pre-requisite of verify-replace script
Related PRs:
Toolchain-common - codeready-toolchain/toolchain-common#429
Host Operator - codeready-toolchain/host-operator#1091
Toolchain-e2e - codeready-toolchain/toolchain-e2e#1049
Registration service - codeready-toolchain/registration-service#465
Ksctl - kubesaw/ksctl#81