-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KUBESAW-192: Introduce a make command for pre-requisite of verify-replace script #429
Conversation
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #429 +/- ##
=======================================
Coverage 77.47% 77.47%
=======================================
Files 49 49
Lines 2007 2007
=======================================
Hits 1555 1555
Misses 398 398
Partials 54 54 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍 . Thanks for addressing my comments.
You'll need to merge kubesaw/ksctl#81 since now the verify-replace-run
would fail without that.
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
Quality Gate passedIssues Measures |
Introduce a make command for pre-requisite of verify-replace script as host-operator and member operator require tiers and assets to be ready before any changes to go mod
Related PRs:
Host Operator - codeready-toolchain/host-operator#1091
Member Operator - codeready-toolchain/member-operator#599
Toolchain-e2e - codeready-toolchain/toolchain-e2e#1049
Registration service - codeready-toolchain/registration-service#465
Ksctl - kubesaw/ksctl#81