KUBESAW-192: Introduce a make command for pre-requisite of verify-replace script #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
fbm3307
requested review from
MatousJobanek,
xcoulon,
alexeykazakov,
rajivnathan,
ranakan19,
sbryzak and
mfrancisc
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #429 +/- ##
=======================================
Coverage 77.47% 77.47%
=======================================
Files 49 49
Lines 2007 2007
=======================================
Hits 1555 1555
Misses 398 398
Partials 54 54 |
This was referenced Sep 24, 2024
mfrancisc
reviewed
Sep 24, 2024
mfrancisc
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Looks good to me 👍 . Thanks for addressing my comments.
You'll need to merge kubesaw/ksctl#81 since now the verify-replace-run would fail without that.
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
|
MatousJobanek
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a make command for pre-requisite of verify-replace script as host-operator and member operator require tiers and assets to be ready before any changes to go mod
Related PRs:
Host Operator - codeready-toolchain/host-operator#1091
Member Operator - codeready-toolchain/member-operator#599
Toolchain-e2e - codeready-toolchain/toolchain-e2e#1049
Registration service - codeready-toolchain/registration-service#465
Ksctl - kubesaw/ksctl#81