Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows: add cuda 11.3 / 11.4 / 11.5 #154

Merged
merged 8 commits into from
Oct 26, 2021
Merged

Windows: add cuda 11.3 / 11.4 / 11.5 #154

merged 8 commits into from
Oct 26, 2021

Conversation

jaimergp
Copy link
Member

@jaimergp jaimergp commented Jun 28, 2021 •
edited
Loading

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

See conda-forge/cudatoolkit-feedstock#58 for more info

@jaimergp jaimergp requested a review from a team as a code owner June 28, 2021 11:56
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jaimergp
Copy link
Member Author

@conda-forge-admin, please rerender

@h-vetinari h-vetinari mentioned this pull request Jun 28, 2021
Closed
5 tasks
@jaimergp jaimergp changed the title add cuda 11.3 Windows: add cuda 11.3 / 11.4 Jul 1, 2021
@jakirkham
Copy link
Member

There are some conflicts. Could you please resolve those Jaime?

@jakirkham
Copy link
Member

Am thinking we won't need these with CUDA Enhanced Compatibility ( conda-forge/nvcc-feedstock#71 ), but please let me know if I'm missing something, Jaime 🙂

Looks like we already have CUDA 11.2 here as well, which is the only other thing I think we need

@kkraus14
Copy link
Contributor

kkraus14 commented Oct 1, 2021

Am thinking we won't need these with CUDA Enhanced Compatibility ( conda-forge/nvcc-feedstock#71 ), but please let me know if I'm missing something, Jaime 🙂

Looks like we already have CUDA 11.2 here as well, which is the only other thing I think we need

I think just because we're enabling CUDA enhanced compatibility doesn't mean that package(s) couldn't opt into using CUDA 11.3 / 11.4 directly if they need newer features.

@jaimergp
Copy link
Member Author

jaimergp commented Oct 3, 2021

For CEC I think we are fine with 11.2, but I guess it doesn't hurt to have .3 and .4 available in case somebody requests it (even for debugging runs) through the CBC.

@leofang leofang mentioned this pull request Oct 26, 2021
Merged
5 tasks
@leofang
Copy link
Member

leofang commented Oct 26, 2021

This PR blocks conda-forge/nvcc-feedstock#74.

@jaimergp
Copy link
Member Author

I'll add 11.5 while we are at it.

@jaimergp jaimergp changed the title Windows: add cuda 11.3 / 11.4 Windows: add cuda 11.3 / 11.4 / 11.5 Oct 26, 2021
leofang
leofang approved these changes Oct 26, 2021
View reviewed changes
Copy link
Member

@leofang leofang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than a typo. Thanks, Jaime!

recipe/install_cuda.bat Outdated Show resolved Hide resolved
@jaimergp @leofang
114->115
3c22e52 
Co-authored-by: Leo Fang <leo80042@gmail.com>
@kkraus14
Copy link
Contributor

LGTM, thanks @jaimergp

@kkraus14 kkraus14 added the automerge Merge the PR when CI passes label Oct 26, 2021
@github-actions github-actions bot merged commit ea5064e into conda-forge:master Oct 26, 2021
@github-actions
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • drone: passed
  • travis: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@h-vetinari h-vetinari mentioned this pull request Nov 11, 2021
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leofang leofang leofang approved these changes

@kkraus14 kkraus14 kkraus14 approved these changes

Assignees
No one assigned
Labels
automerge Merge the PR when CI passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jaimergp @conda-forge-linter @jakirkham @kkraus14 @leofang