Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CUDA 11.3/11.4/11.5 #74

Merged
merged 6 commits into from
Jan 21, 2022
Merged

Add CUDA 11.3/11.4/11.5 #74

merged 6 commits into from
Jan 21, 2022

Conversation

ajschmidt8
Copy link
Contributor

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Similar to #69, except it also adds 11.5 and has no merge conflicts 🙂

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@leofang
Copy link
Member

leofang commented Oct 25, 2021

Hi @ajschmidt8, since you're touching this feedstock, could you change all cos8 occurrences to cos7 in recipe/conda_build_config.yaml and rerender please? It was a mistake we made earlier. The only impact of this change is on the package hash string, but since you're bumping the build number anyway it doesn't matter.

@leofang
Copy link
Member

leofang commented Oct 26, 2021

Hi @isuruf, looks like the CUDA 11.5 docker images are currently not visible? Could you check for us please?

@ajschmidt8
Copy link
Contributor Author

ajschmidt8 commented Oct 26, 2021

For reference, I have a PR to add 11.5 images below. This PR will likely continue to fail until it's merged. However, I think that PR is dependent on the 11.5 variants of the nvidia/cuda DockerHub images being published

@leofang
Copy link
Member

leofang commented Oct 26, 2021

Thanks AJ, I mistakenly thought the 11.5 image has been added, my bad!

@leofang
Copy link
Member

leofang commented Oct 26, 2021

btw for Windows, we need this PR conda-forge/conda-forge-ci-setup-feedstock#154 to be merged (and add 11.5 support on top of that).

@jaimergp
Copy link
Member

Fixed conflicts and added 11.5 there!

@kkraus14
Copy link
Contributor

We may also be blocked by conda-forge/docker-images#198 here

@leofang
Copy link
Member

leofang commented Jan 21, 2022

@conda-forge-admin, please rerender

@kkraus14 kkraus14 merged commit 203aada into conda-forge:master Jan 21, 2022
@kkraus14
Copy link
Contributor

Thanks @ajschmidt8!

@kkraus14 kkraus14 mentioned this pull request Jan 21, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants