AA: use URL safe base64 encoding for TeePubKey #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiangliu
approved these changes
Jun 26, 2023
|
Thanks @katexochen . I guess this PR will have to be modified with the new kbs-types release. Otherwise LGTM. |
sameo
approved these changes
Jul 5, 2023
|
@sameo I have that change prepared, but I'm still waiting for the crate to be published: https://crates.io/crates/kbs-types/versions |
sameo
approved these changes
Jul 7, 2023
|
It seems that we have a unit test failure @katexochen |
|
@sameo The failing test isn't related to my change, right? This seems to be the failure mentioned in https://app.slack.com/client/T08PSQ7BQ/C050S70D9SR/thread/C050S70D9SR-1688691629.377139 |
Closed
Closed
3 tasks
|
Hi @katexochen , could you please rebase the code? I think the error here has been fixed. |
Signed-off-by: Paul Meyer <49727155+katexochen@users.noreply.github.com>
Signed-off-by: Paul Meyer <49727155+katexochen@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of confidential-containers/attestation-agent#211
Fixes #184