-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove stale references to packet-server in channel/v2. #7451
Conversation
) | ||
|
||
// GetQueryCmd returns the query commands for the IBC packet-server. | ||
// GetQueryCmd returns the query commands for the IBC channel/v2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
happy for something different than channel/v2
if folks have ideas.
c3ed628
to
cad965f
Compare
Quality Gate passed for 'ibc-go'Issues Measures |
) | ||
|
||
// GetQueryCmd returns the query commands for the IBC packet-server. | ||
// GetQueryCmd returns the query commands for the IBC channel/v2. | ||
func GetQueryCmd() *cobra.Command { | ||
queryCmd := &cobra.Command{ | ||
Use: types.SubModuleName, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the usage simd q ibc channelv2
right now? I wonder if its possible to have /
in SubModuleName, so that we could use simd q ibc channel/v2
I guess its just aesthetic preference
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ikr. bank/v2 does same though
so at least, precedence
Description
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
).godoc
comments.Files changed
in the GitHub PR explorer.SonarCloud Report
in the comment section below once CI passes.