Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove stale references to packet-server in channel/v2. #7451

Merged
merged 1 commit into from
Oct 15, 2024
Merged

chore: remove stale references to packet-server in channel/v2. #7451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions modules/core/04-channel/v2/client/cli/cli.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,14 @@ import (

"github.com/cosmos/cosmos-sdk/client"

"github.com/cosmos/ibc-go/v9/modules/core/packet-server/types"
"github.com/cosmos/ibc-go/v9/modules/core/04-channel/v2/types"
)

// GetQueryCmd returns the query commands for the IBC packet-server.
// GetQueryCmd returns the query commands for the IBC channel/v2.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

happy for something different than channel/v2 if folks have ideas.

func GetQueryCmd() *cobra.Command {
queryCmd := &cobra.Command{
Use: types.SubModuleName,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the usage simd q ibc channelv2 right now? I wonder if its possible to have / in SubModuleName, so that we could use simd q ibc channel/v2

I guess its just aesthetic preference

Copy link
Contributor Author

@DimitrisJim DimitrisJim Oct 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ikr. bank/v2 does same though

https://github.com/cosmos/cosmos-sdk/blob/77254b735b613d53f6acfcb8ea1709b95de446f7/x/bank/v2/types/keys.go#L9

so at least, precedence

Short: "IBC packet-server query subcommands",
Short: "IBC channel/v2 query subcommands",
DisableFlagParsing: true,
SuggestionsMinimumDistance: 2,
RunE: client.ValidateCmd,
Expand All @@ -25,11 +25,11 @@ func GetQueryCmd() *cobra.Command {
return queryCmd
}

// NewTxCmd returns the command to submit transactions defined for the IBC packet-server.
// NewTxCmd returns the command to submit transactions defined for IBC channel/v2.
func NewTxCmd() *cobra.Command {
txCmd := &cobra.Command{
Use: types.SubModuleName,
Short: "IBC packet-server transaction subcommands",
Short: "IBC channel/v2 transaction subcommands",
DisableFlagParsing: true,
SuggestionsMinimumDistance: 2,
RunE: client.ValidateCmd,
Expand Down
2 changes: 1 addition & 1 deletion modules/core/04-channel/v2/keeper/grpc_query.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import (

var _ types.QueryServer = (*queryServer)(nil)

// queryServer implements the packet-server types.QueryServer interface.
// queryServer implements the channel/v2 types.QueryServer interface.
type queryServer struct {
*Keeper
}
Expand Down
Loading