This repository has been archived by the owner on Feb 22, 2018. It is now read-only.
fix(HttpConfig): Remove the optional argument to the default ctor #1285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM I though @antingshen had fixed DI to make this possible, though. |
|
@jbdeboer can I merge this one into master ? I've linked di/153 in the PR above but it would not make that possible IIUC (possibly because of a dart2js bug) |
Because this is not currently supported by the Dependency injection. A new HttpConfig.withOptions() ctor has been added.
vicb
added a commit
that referenced
this pull request
Aug 1, 2014
Because this is not currently supported by the Dependency injection. A new HttpConfig.withOptions() ctor has been added. Closes #1285
|
LGTM, let's make sure we merge this before 0.14, the warnings are really annoying. |
| @@ -755,5 +755,7 @@ class Http { | |||
| class HttpConfig { | |||
| final Duration coalesceDuration; | |||
|
|
|||
| HttpConfig({this.coalesceDuration}); | |||
| HttpConfig(): coalesceDuration = null; | |||
There was a problem hiding this comment.
"Uninitialized variables have an initial value of null." from the dart spec, but no downside to be extra explicit.
vicb
added a commit
that referenced
this pull request
Aug 15, 2014
Because this is not currently supported by the Dependency injection. A new HttpConfig.withOptions() ctor has been added. Closes #1285
dsalsbury
pushed a commit
to dsalsbury/angular.dart
that referenced
this pull request
Aug 16, 2014
Because this is not currently supported by the Dependency injection. A new HttpConfig.withOptions() ctor has been added. Closes dart-archive#1285
vicb
added a commit
that referenced
this pull request
Aug 19, 2014
Because this is not currently supported by the Dependency injection. A new HttpConfig.withOptions() ctor has been added. Closes #1285
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because this is not currently supported by the Dependency injection.
A new HttpConfig.withOptions() ctor has been added.
This PR fix a warning reported by the analyzer because of the code generated by the DI transformers.