Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix databricks_mws_private_access_settings creation #3439

Merged
merged 4 commits into from
Apr 15, 2024
Merged

Fix databricks_mws_private_access_settings creation #3439

merged 4 commits into from
Apr 15, 2024

Conversation

nkvuong
Copy link
Contributor

@nkvuong nkvuong commented Apr 5, 2024 •
edited
Loading

Changes

Tests

  • make test run locally
  • relevant change in docs/ folder
  • using Go SDK

@nkvuong nkvuong requested review from a team as code owners April 5, 2024 17:57
@nkvuong nkvuong requested review from tanmay-db and removed request for a team April 5, 2024 17:57
alexott
alexott approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@alexott alexott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comment

mws/resource_mws_private_access_settings.go Show resolved Hide resolved
@nkvuong nkvuong added this pull request to the merge queue Apr 15, 2024
Merged via the queue into main with commit 0b183af Apr 15, 2024
5 checks passed
@nkvuong nkvuong deleted the fix/mws_pas branch April 15, 2024 09:02
@tanmay-db tanmay-db mentioned this pull request Apr 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexott alexott alexott approved these changes

@tanmay-db tanmay-db tanmay-db approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ISSUE] Issue with databricks_mws_private_access_settings resource
3 participants
@nkvuong @alexott @tanmay-db