Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing properties to diff detection for databricks_sql_table #3465

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

nkvuong
Copy link
Contributor

@nkvuong nkvuong commented Apr 15, 2024

Changes

Closes #3455

Tests

  • make test run locally
  • manually tested
  • relevant acceptance tests are passing
  • using Go SDK

@nkvuong nkvuong requested review from a team as code owners April 15, 2024 11:01
@nkvuong nkvuong requested review from tanmay-db and removed request for a team April 15, 2024 11:01
@nkvuong nkvuong changed the title Add missing properties diff detection for databricks_sql_table Add missing properties to diff detection for databricks_sql_table Apr 15, 2024
@alexott alexott added this pull request to the merge queue Apr 15, 2024
Merged via the queue into main with commit 9a3315f Apr 15, 2024
5 checks passed
@alexott alexott deleted the fix/sql_table branch April 15, 2024 14:41
@vsluc
Copy link

vsluc commented Apr 15, 2024

Thanks @nkvuong for addressing this quickly. Much helpful!

@tanmay-db tanmay-db mentioned this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ISSUE] Issue with databricks_sql_table resource - detects changes unnecessarily
4 participants